From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D8BDC43334 for ; Tue, 14 Jun 2022 14:31:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345066AbiFNObh (ORCPT ); Tue, 14 Jun 2022 10:31:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344177AbiFNObd (ORCPT ); Tue, 14 Jun 2022 10:31:33 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10605396AA for ; Tue, 14 Jun 2022 07:31:33 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id r1so7882349plo.10 for ; Tue, 14 Jun 2022 07:31:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8wgnDbW6NGQNGKOrZNLtKpgaJzK7o8Ip4VysdMD2fJo=; b=h9FRnHKHUsz5BuVrVVD4chBYaw1pIKvY6OGId4hNo59q52AS95tAEtTZGpCR52o+H1 XjJEDblkPdPP/p74VQkeRhn70ZeP5grzOx2U21UqKToKdr7C2GSLdnthmxRIi88uOsun wFGODbHHMtgEOhsDpBTSI8QQD3H80oJrGcnyaT04U4gOAHVA4+JWC7RFb9SOl1GXzYCB rSUSyfT6P2rfB5mEJDVN6IVquonTii5PpI8Z5TOeDQqc9p9r3vxzAFhdCxy0ed7Qi//X gpC+Ph6H24yvEziAn6fkbeBHmp2Cz1cRLcQBEc+YTip0UazS4jGf5fi2avPm8Cnve8Km wnVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8wgnDbW6NGQNGKOrZNLtKpgaJzK7o8Ip4VysdMD2fJo=; b=TdhhXVjA2XRGO0T0UTmxanOH+urNvK9edJA7Ems0LE3jk/jkSzxnLBIXVHf6HJOVLd 511TeUy+zy/hD7pHmt9Po74Qg42idIGV0yvZZbfj6mCa1eiMuNy5jgLGf0pfKra36EwI Bt9pD7hI8T0nejoBlr6QwQyneJ3QVd8DMjrSReDzy6Qt2g3oyHI7GSbeEAIw96kKr5x+ F1qjDMpAU9CIzrG9K63+2zGqe1eMq1D/L3h21dt+SeMHd0UpLyJ8yOdPDA9ETr/PnxkQ E7mgHNkpul1WarHWYEH95mygn/OKzldnVd9H9Ak4CPSV9MN4W6iBzTtqeXGSHTzV6dpj aIFA== X-Gm-Message-State: AJIora9a5GI6wdzaAx6x19BJvKWZU8Opn3Gy/D9oEJvcB9R1zq25UxVV /bh5nWWwYmLTh2sjEtQfmS7/sw== X-Google-Smtp-Source: AGRyM1tjyXRgWoodAOm08P85asq1len4o2tsDgTGN9csMEnGsrMwvf3L4n9XVEdupJgZwENX///vKw== X-Received: by 2002:a17:90b:4c4c:b0:1e8:6f9a:b642 with SMTP id np12-20020a17090b4c4c00b001e86f9ab642mr4914312pjb.21.1655217092296; Tue, 14 Jun 2022 07:31:32 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id z1-20020a626501000000b0050dc7628183sm7874342pfb.93.2022.06.14.07.31.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 07:31:31 -0700 (PDT) Date: Tue, 14 Jun 2022 14:31:28 +0000 From: Sean Christopherson To: Lai Jiangshan Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , "open list:KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips)" , LKML Subject: Re: [PATCH 1/8] KVM: x86/mmu: Drop unused CMPXCHG macro from paging_tmpl.h Message-ID: References: <20220613225723.2734132-1-seanjc@google.com> <20220613225723.2734132-2-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 14, 2022, Lai Jiangshan wrote: > On Tue, Jun 14, 2022 at 6:59 AM Sean Christopherson wrote: > > > > Drop the CMPXCHG macro from paging_tmpl.h, it's no longer used now that > > KVM uses a common uaccess helper to do 8-byte CMPXCHG. > > > > Fixes: f122dfe44768 ("KVM: x86: Use __try_cmpxchg_user() to update guest PTE A/D bits") > > Signed-off-by: Sean Christopherson > > > In https://lore.kernel.org/lkml/20220605063417.308311-2-jiangshanlai@gmail.com/ > two other unused macros are also removed. I'd prefer to keep them around as it allows using them to generate the other masks that are used. My apologies for colliding with your series, I saw it flash by but didn't look at what it contained. If it's ok with you, I'll grab patches 1-3 from your series, tweak patch 1 to drop only CMPXCH, and send them as the basis of v2 for the rest of the patches in this series.