From: Greg KH <gregkh@linuxfoundation.org>
To: Zhi Song <zhi.song@bytedance.com>
Cc: rafael@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] node: put_device after failing to device_register
Date: Tue, 14 Jun 2022 16:37:56 +0200 [thread overview]
Message-ID: <YqidROu44rHFaI6w@kroah.com> (raw)
In-Reply-To: <20220614143007.1730171-1-zhi.song@bytedance.com>
On Tue, Jun 14, 2022 at 10:30:07PM +0800, Zhi Song wrote:
> device_register() is used to register a device with the system.
>
> We cannot directly free dev after calling this function,
> even if it returns an error.
the device is not being freed, why say this?
And you do have a full 72 columns to use :)
>
> We should use put_device() to give up the reference
> initialized in this function instead.
There is no "instead" happening here. The patch looks correct, but this
changelog text does not. Please fix up.
thanks,
greg k-h
next prev parent reply other threads:[~2022-06-14 14:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 14:30 [PATCH] node: put_device after failing to device_register Zhi Song
2022-06-14 14:37 ` Greg KH [this message]
2022-06-22 17:12 ` [External] " Zhi Song
-- strict thread matches above, loose matches on Subject: below --
2022-06-14 16:00 Zhi Song
2022-06-14 16:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqidROu44rHFaI6w@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=zhi.song@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox