From: Greg KH <gregkh@linuxfoundation.org>
To: wuchi <wuchi.zero@gmail.com>
Cc: alexios.zavras@intel.com, allison@lohutok.net, armijn@tjaldur.nl,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/klist: Remove mb() before wake_up_process
Date: Tue, 14 Jun 2022 16:58:19 +0200 [thread overview]
Message-ID: <YqiiC+4xES0DoV7X@kroah.com> (raw)
In-Reply-To: <20220614144443.6566-1-wuchi.zero@gmail.com>
On Tue, Jun 14, 2022 at 10:44:43PM +0800, wuchi wrote:
> Function wake_up_process always executes a general memory barrier,
> so remove the mb() before it.
Really? On all systems? I do not see that, where does it happen?
> Signed-off-by: wuchi <wuchi.zero@gmail.com>
We need a "real name" for commits.
How did you test this patch?
thanks,
greg k-h
next prev parent reply other threads:[~2022-06-14 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 14:44 [PATCH] lib/klist: Remove mb() before wake_up_process wuchi
2022-06-14 14:58 ` Greg KH [this message]
2022-06-15 3:30 ` chi wu
2022-06-15 6:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqiiC+4xES0DoV7X@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=armijn@tjaldur.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=wuchi.zero@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox