From: Greg KH <gregkh@linuxfoundation.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Bard Liao <yung-chuan.liao@linux.intel.com>,
alsa-devel@alsa-project.org, vkoul@kernel.org,
vinod.koul@linaro.org, linux-kernel@vger.kernel.org,
tiwai@suse.de, broonie@kernel.org,
srinivas.kandagatla@linaro.org, sanyog.r.kale@intel.com,
bard.liao@intel.com
Subject: Re: [PATCH 2/2] ASoC: SOF: Intel: add trigger callback into sdw_callback
Date: Tue, 14 Jun 2022 17:14:37 +0200 [thread overview]
Message-ID: <Yqil3UDSmoXN3E9M@kroah.com> (raw)
In-Reply-To: <3fd14acb-1de9-3fd8-81ab-27fee4a42b84@linux.intel.com>
On Tue, Jun 14, 2022 at 09:55:41AM -0500, Pierre-Louis Bossart wrote:
>
> >> @@ -809,6 +814,10 @@ void hda_set_dai_drv_ops(struct snd_sof_dev *sdev, struct snd_sof_dsp_ops *ops)
> >> if (!hda_use_tplg_nhlt)
> >> ipc4_data->nhlt = intel_nhlt_init(sdev->dev);
> >>
> >> +#if IS_ENABLED(CONFIG_SND_SOC_SOF_INTEL_SOUNDWIRE)
> >> + sdw_callback.trigger = ipc4_be_dai_common_trigger;
> >> +#endif
> >
> > #if should not be in .c files if at all possible. Surely there's a
> > better way here...
>
> we could use
>
> if (IS_ENABLED(CONFIG_SND_SOC_SOF_INTEL_SOUNDWIRE))
> sdw_callback.trigger = ipc4_be_dai_common_trigger;
>
> would that work?
It's more readable, right? Also easier to maintain over time.
> We try to keep this driver configurable, not all platforms require
> SoundWire or HDaudio, and that 'sdw_callback' ops structure is
> conditionally declared.
Perhaps don't conditionally declare that? How much does it really save
to do that?
thanks,
greg k-h
next prev parent reply other threads:[~2022-06-14 15:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 7:08 [PATCH 0/2] ASoC/SoundWire: Intel: add sdw BE dai trigger Bard Liao
2022-06-14 7:08 ` [PATCH 1/2] soundwire: Intel: add trigger callback Bard Liao
2022-06-14 7:08 ` [PATCH 2/2] ASoC: SOF: Intel: add trigger callback into sdw_callback Bard Liao
2022-06-14 7:12 ` Greg KH
2022-06-14 14:55 ` Pierre-Louis Bossart
2022-06-14 15:14 ` Greg KH [this message]
2022-06-14 15:54 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yqil3UDSmoXN3E9M@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vinod.koul@linaro.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox