Re: [PATCH 1/2] iio: adc: stx104: Implement and utilize register structures

William Breathitt Gray
2022-06-15T12:19:38Z

[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]

On Wed, Jun 15, 2022 at 02:00:26PM +0200, Andy Shevchenko wrote:
> On Wed, Jun 15, 2022 at 1:55 PM William Breathitt Gray
> <william.gray@linaro.org> wrote:
> > On Wed, Jun 15, 2022 at 11:44:54AM +0200, Andy Shevchenko wrote:
> > > On Mon, Jun 6, 2022 at 4:27 PM William Breathitt Gray
> > > <william.gray@linaro.org> wrote:
> > > >
> > > > Reduce magic numbers and improve code readability by implementing and
> > > > utilizing named register data structures.
> > >
> > > Can we consider using regmap APIs instead?
>
> > The regmap API may be more appropriate here. I'll investigate and see if
> > I can convert this over to it.
>
> I just realized that this driver is for the old PC104 (like?) hardware
> that most likely uses IO ports, I don't remember if we have support
> for IO ports in regmap (MMIO -- yes for sure).
>
> --
> With Best Regards,
> Andy Shevchenko

Hmm, I don't see IO ports mentioned in include/linux/regmap.h, so I
don't think the regmap API directly supports it (maybe someone familiar
with regmap knows). Although we do get a virtual mapping cookie via
ioport_map() in this driver, I don't know if we can pass that to the
regmap functions and have it actually work.

William Breathitt Gray

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]