Re: [v4 PATCH 7/7] doc: proc: fix the description to THPeligible

Zach O'Keefe
2022-06-16T00:20:27Z

On 15 Jun 10:29, Yang Shi wrote:
> The THPeligible bit shows 1 if and only if the VMA is eligible for
> allocating THP and the THP is also PMD mappable. Some misaligned file
> VMAs may be eligible for allocating THP but the THP can't be mapped by
> PMD. Make this more explictly to avoid ambiguity.
>
> Signed-off-by: Yang Shi <shy828301@gmail.com>
> ---
> Documentation/filesystems/proc.rst | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
> index 1bc91fb8c321..a5e41e636a1a 100644
> --- a/Documentation/filesystems/proc.rst
> +++ b/Documentation/filesystems/proc.rst
> @@ -514,8 +514,10 @@ replaced by copy-on-write) part of the underlying shmem object out on swap.
> "SwapPss" shows proportional swap share of this mapping. Unlike "Swap", this
> does not take into account swapped out page of underlying shmem objects.
> "Locked" indicates whether the mapping is locked in memory or not.
> +
> "THPeligible" indicates whether the mapping is eligible for allocating THP
> -pages - 1 if true, 0 otherwise. It just shows the current status.
> +pages as well as the THP is PMD mappable or not - 1 if true, 0 otherwise.
> +It just shows the current status.
>
> "VmFlags" field deserves a separate description. This member represents the
> kernel flags associated with the particular virtual memory area in two letter
> --
> 2.26.3
>

Thanks for updating this!

Reviewed-by: Zach O'Keefe <zokeefe@google.com>