* [PATCH] mfd: max77620: Fix refcount leak in max77620_initialise_fps
@ 2022-06-01 4:32 Miaoqian Lin
2022-06-01 10:52 ` Krzysztof Kozlowski
2022-06-15 21:44 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Miaoqian Lin @ 2022-06-01 4:32 UTC (permalink / raw)
To: Lee Jones, Mallikarjun Kasoju, Krzysztof Kozlowski,
Laxman Dewangan, linux-kernel
Cc: linmq006
of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: 327156c59360 ("mfd: max77620: Add core driver for MAX77620/MAX20024")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/mfd/max77620.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c
index fec2096474ad..a6661e07035b 100644
--- a/drivers/mfd/max77620.c
+++ b/drivers/mfd/max77620.c
@@ -419,9 +419,11 @@ static int max77620_initialise_fps(struct max77620_chip *chip)
ret = max77620_config_fps(chip, fps_child);
if (ret < 0) {
of_node_put(fps_child);
+ of_node_put(fps_np);
return ret;
}
}
+ of_node_put(fps_np);
config = chip->enable_global_lpm ? MAX77620_ONOFFCNFG2_SLP_LPM_MSK : 0;
ret = regmap_update_bits(chip->rmap, MAX77620_REG_ONOFFCNFG2,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: max77620: Fix refcount leak in max77620_initialise_fps
2022-06-01 4:32 [PATCH] mfd: max77620: Fix refcount leak in max77620_initialise_fps Miaoqian Lin
@ 2022-06-01 10:52 ` Krzysztof Kozlowski
2022-06-15 21:44 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-01 10:52 UTC (permalink / raw)
To: Miaoqian Lin, Lee Jones, Mallikarjun Kasoju, Laxman Dewangan,
linux-kernel
On 01/06/2022 06:32, Miaoqian Lin wrote:
> of_get_child_by_name() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 327156c59360 ("mfd: max77620: Add core driver for MAX77620/MAX20024")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: max77620: Fix refcount leak in max77620_initialise_fps
2022-06-01 4:32 [PATCH] mfd: max77620: Fix refcount leak in max77620_initialise_fps Miaoqian Lin
2022-06-01 10:52 ` Krzysztof Kozlowski
@ 2022-06-15 21:44 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2022-06-15 21:44 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Mallikarjun Kasoju, Krzysztof Kozlowski, Laxman Dewangan,
linux-kernel
On Wed, 01 Jun 2022, Miaoqian Lin wrote:
> of_get_child_by_name() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 327156c59360 ("mfd: max77620: Add core driver for MAX77620/MAX20024")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> drivers/mfd/max77620.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-15 21:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-01 4:32 [PATCH] mfd: max77620: Fix refcount leak in max77620_initialise_fps Miaoqian Lin
2022-06-01 10:52 ` Krzysztof Kozlowski
2022-06-15 21:44 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox