public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Ene <sebastianene@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rob Herring <robh+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Dragan Cvetic <dragan.cvetic@xilinx.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	maz@kernel.org, will@kernel.org, vdonnefort@google.com,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v6 2/2] misc: Add a mechanism to detect stalls on guest vCPUs
Date: Thu, 16 Jun 2022 16:01:17 +0000	[thread overview]
Message-ID: <YqtTzehgcxRpoiyF@google.com> (raw)
In-Reply-To: <YqsBN2qtjCkNtVM0@kroah.com>

On Thu, Jun 16, 2022 at 12:08:55PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Jun 16, 2022 at 09:27:39AM +0000, Sebastian Ene wrote:
> > This driver creates per-cpu hrtimers which are required to do the
> > periodic 'pet' operation. On a conventional watchdog-core driver, the
> > userspace is responsible for delivering the 'pet' events by writing to
> > the particular /dev/watchdogN node. In this case we require a strong
> > thread affinity to be able to account for lost time on a per vCPU.
> > 
> > This part of the driver is the 'frontend' which is reponsible for
> > delivering the periodic 'pet' events, configuring the virtual peripheral
> > and listening for cpu hotplug events. The other part of the driver
> > handles the peripheral emulation and this part accounts for lost time by
> > looking at the /proc/{}/task/{}/stat entries and is located here:
> > https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3548817
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> 

Hi,

> The robot reported stalls on vcpus?
> 
> I think you need to fix this up...

The robot reported some issues on v5 and after fixing them it
recommended to add this tag.

> 
> greg k-h

Thanks,
Seb

  parent reply	other threads:[~2022-06-16 16:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16  9:27 [PATCH v6 0/2] Detect stalls on guest vCPUS Sebastian Ene
2022-06-16  9:27 ` [PATCH v6 1/2] dt-bindings: vcpu_stall_detector: Add qemu,vcpu-stall-detector compatible Sebastian Ene
2022-06-16 14:05   ` Rob Herring
2022-06-16 15:30   ` Rob Herring
2022-06-16  9:27 ` [PATCH v6 2/2] misc: Add a mechanism to detect stalls on guest vCPUs Sebastian Ene
2022-06-16 10:08   ` Greg Kroah-Hartman
2022-06-16 13:08     ` Guenter Roeck
2022-06-16 16:05       ` Sebastian Ene
2022-06-16 16:01     ` Sebastian Ene [this message]
2022-06-16 16:09       ` Guenter Roeck
2022-06-16 10:10   ` Greg Kroah-Hartman
2022-06-16 16:03     ` Sebastian Ene

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YqtTzehgcxRpoiyF@google.com \
    --to=sebastianene@google.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dragan.cvetic@xilinx.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=maz@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=vdonnefort@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox