From: Nathan Chancellor <nathan@kernel.org>
To: HighW4y2H3ll <huzh@nyu.edu>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix use of uninitialized variable in rts5261_init_from_hw, when efuse_valid == 1.
Date: Fri, 17 Jun 2022 11:40:45 -0700 [thread overview]
Message-ID: <YqzKrdI0JBORlptt@dev-arch.thelio-3990X> (raw)
In-Reply-To: <20220617044755.37535-1-huzh@nyu.edu>
On Fri, Jun 17, 2022 at 12:47:55AM -0400, HighW4y2H3ll wrote:
> Signed-off-by: zhenghao hu <huzh@nyu.edu>
> ---
> drivers/misc/cardreader/rts5261.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/cardreader/rts5261.c b/drivers/misc/cardreader/rts5261.c
> index 749cc5a46d13..f22634b14dc8 100644
> --- a/drivers/misc/cardreader/rts5261.c
> +++ b/drivers/misc/cardreader/rts5261.c
> @@ -403,7 +403,7 @@ static void rts5261_init_from_hw(struct rtsx_pcr *pcr)
> setting_reg1 = PCR_SETTING_REG4;
> setting_reg2 = PCR_SETTING_REG5;
> }
> - } else if (efuse_valid == 0) {
> + } else {
> // default
> setting_reg1 = PCR_SETTING_REG1;
> setting_reg2 = PCR_SETTING_REG2;
> --
> 2.35.1
>
I know Greg already replied but this has been fixed already [1]. Due to
a small snafu [2], it won't make 5.19-rc3 but I hope it will be fixed in
5.19-rc4.
[1]: https://git.kernel.org/gregkh/char-misc/c/bd476c1306ea989d6d9eb65295572e98d93edeb6
[2]: https://lore.kernel.org/CE205655-557F-486C-AF6A-099749208327@kroah.com/
Cheers,
Nathan
next prev parent reply other threads:[~2022-06-17 18:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 4:47 [PATCH] Fix use of uninitialized variable in rts5261_init_from_hw, when efuse_valid == 1 HighW4y2H3ll
2022-06-17 6:33 ` Greg Kroah-Hartman
2022-06-17 18:40 ` Nathan Chancellor [this message]
2022-06-17 19:01 ` Zhenghao Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqzKrdI0JBORlptt@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=huzh@nyu.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox