From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FA85C43334 for ; Fri, 17 Jun 2022 18:40:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232003AbiFQSkw (ORCPT ); Fri, 17 Jun 2022 14:40:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230253AbiFQSkv (ORCPT ); Fri, 17 Jun 2022 14:40:51 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8940735248 for ; Fri, 17 Jun 2022 11:40:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 42D50B82B67 for ; Fri, 17 Jun 2022 18:40:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88FCFC3411B; Fri, 17 Jun 2022 18:40:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655491247; bh=n1lMVZHWVS0s9aDUcOtGjcugDZEPYPqWAceVrfKJziE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bllBknQfo46lK+t1UGHu5aGmd06g7XjsWGWnzWmnjLS9WZN3el6Sn6e1xs8vYeQFO IF89QLRSpSERHH+Lj2NQ4I2sCX/GeD8qcKFpMKnmBuDwu+cim8pzGtCOAJBfagJEwS QLNFsb/NcuYn3HU7dNf3D5SZsDb3dKC8yCV4jcGISWFJV1vOIeL9MaihKnG/onXbWb 3kL3DoUbr0SOFiP/R5G2mQim/U0QnZtaBEglQt54p63vdS7LwUKtUy83rXxVvcQLlx K62HaqnltGH5RYcLP3aHisBh1lAV6lUsB4Mn+dxKb1yPaRnpJ6Rov6SHDjpFdr8WZj JlaSo35snxlnA== Date: Fri, 17 Jun 2022 11:40:45 -0700 From: Nathan Chancellor To: HighW4y2H3ll Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix use of uninitialized variable in rts5261_init_from_hw, when efuse_valid == 1. Message-ID: References: <20220617044755.37535-1-huzh@nyu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220617044755.37535-1-huzh@nyu.edu> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 17, 2022 at 12:47:55AM -0400, HighW4y2H3ll wrote: > Signed-off-by: zhenghao hu > --- > drivers/misc/cardreader/rts5261.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/cardreader/rts5261.c b/drivers/misc/cardreader/rts5261.c > index 749cc5a46d13..f22634b14dc8 100644 > --- a/drivers/misc/cardreader/rts5261.c > +++ b/drivers/misc/cardreader/rts5261.c > @@ -403,7 +403,7 @@ static void rts5261_init_from_hw(struct rtsx_pcr *pcr) > setting_reg1 = PCR_SETTING_REG4; > setting_reg2 = PCR_SETTING_REG5; > } > - } else if (efuse_valid == 0) { > + } else { > // default > setting_reg1 = PCR_SETTING_REG1; > setting_reg2 = PCR_SETTING_REG2; > -- > 2.35.1 > I know Greg already replied but this has been fixed already [1]. Due to a small snafu [2], it won't make 5.19-rc3 but I hope it will be fixed in 5.19-rc4. [1]: https://git.kernel.org/gregkh/char-misc/c/bd476c1306ea989d6d9eb65295572e98d93edeb6 [2]: https://lore.kernel.org/CE205655-557F-486C-AF6A-099749208327@kroah.com/ Cheers, Nathan