* Re: [PATCH] Fix use of uninitialized variable in rts5261_init_from_hw, when efuse_valid == 1.
2022-06-17 4:47 [PATCH] Fix use of uninitialized variable in rts5261_init_from_hw, when efuse_valid == 1 HighW4y2H3ll
@ 2022-06-17 6:33 ` Greg Kroah-Hartman
2022-06-17 18:40 ` Nathan Chancellor
1 sibling, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2022-06-17 6:33 UTC (permalink / raw)
To: HighW4y2H3ll; +Cc: Arnd Bergmann, linux-kernel
On Fri, Jun 17, 2022 at 12:47:55AM -0400, HighW4y2H3ll wrote:
> Signed-off-by: zhenghao hu <huzh@nyu.edu>
> ---
> drivers/misc/cardreader/rts5261.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/cardreader/rts5261.c b/drivers/misc/cardreader/rts5261.c
> index 749cc5a46d13..f22634b14dc8 100644
> --- a/drivers/misc/cardreader/rts5261.c
> +++ b/drivers/misc/cardreader/rts5261.c
> @@ -403,7 +403,7 @@ static void rts5261_init_from_hw(struct rtsx_pcr *pcr)
> setting_reg1 = PCR_SETTING_REG4;
> setting_reg2 = PCR_SETTING_REG5;
> }
> - } else if (efuse_valid == 0) {
> + } else {
> // default
> setting_reg1 = PCR_SETTING_REG1;
> setting_reg2 = PCR_SETTING_REG2;
> --
> 2.35.1
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what is needed in order to
properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what a proper Subject: line should
look like.
- It looks like you did not use your "real" name for the patch on either
the Signed-off-by: line, or the From: line (both of which have to
match). Please read the kernel file, Documentation/SubmittingPatches
for how to do this correctly.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Fix use of uninitialized variable in rts5261_init_from_hw, when efuse_valid == 1.
2022-06-17 4:47 [PATCH] Fix use of uninitialized variable in rts5261_init_from_hw, when efuse_valid == 1 HighW4y2H3ll
2022-06-17 6:33 ` Greg Kroah-Hartman
@ 2022-06-17 18:40 ` Nathan Chancellor
2022-06-17 19:01 ` Zhenghao Hu
1 sibling, 1 reply; 4+ messages in thread
From: Nathan Chancellor @ 2022-06-17 18:40 UTC (permalink / raw)
To: HighW4y2H3ll; +Cc: Arnd Bergmann, Greg Kroah-Hartman, linux-kernel
On Fri, Jun 17, 2022 at 12:47:55AM -0400, HighW4y2H3ll wrote:
> Signed-off-by: zhenghao hu <huzh@nyu.edu>
> ---
> drivers/misc/cardreader/rts5261.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/cardreader/rts5261.c b/drivers/misc/cardreader/rts5261.c
> index 749cc5a46d13..f22634b14dc8 100644
> --- a/drivers/misc/cardreader/rts5261.c
> +++ b/drivers/misc/cardreader/rts5261.c
> @@ -403,7 +403,7 @@ static void rts5261_init_from_hw(struct rtsx_pcr *pcr)
> setting_reg1 = PCR_SETTING_REG4;
> setting_reg2 = PCR_SETTING_REG5;
> }
> - } else if (efuse_valid == 0) {
> + } else {
> // default
> setting_reg1 = PCR_SETTING_REG1;
> setting_reg2 = PCR_SETTING_REG2;
> --
> 2.35.1
>
I know Greg already replied but this has been fixed already [1]. Due to
a small snafu [2], it won't make 5.19-rc3 but I hope it will be fixed in
5.19-rc4.
[1]: https://git.kernel.org/gregkh/char-misc/c/bd476c1306ea989d6d9eb65295572e98d93edeb6
[2]: https://lore.kernel.org/CE205655-557F-486C-AF6A-099749208327@kroah.com/
Cheers,
Nathan
^ permalink raw reply [flat|nested] 4+ messages in thread