From: Greg KH <gregkh@linuxfoundation.org>
To: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
konrad.dybcio@somainline.org, jirislaby@kernel.org,
linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_msavaliy@quicinc.com,
dianders@chromium.org, mka@chromium.org, swboyd@chromium.org
Subject: Re: [V2] tty: serial: qcom-geni-serial: Fix get_clk_div_rate() which otherwise could return a sub-optimal clock rate.
Date: Thu, 30 Jun 2022 17:00:49 +0200 [thread overview]
Message-ID: <Yr26oSKOhIBMaKsS@kroah.com> (raw)
In-Reply-To: <1656496841-5853-1-git-send-email-quic_vnivarth@quicinc.com>
On Wed, Jun 29, 2022 at 03:30:41PM +0530, Vijaya Krishna Nivarthi wrote:
> In the logic around call to clk_round_rate(), for some corner conditions,
> get_clk_div_rate() could return an sub-optimal clock rate. Also, if an
> exact clock rate was not found lowest clock was being returned.
>
> Search for suitable clock rate in 2 steps
> a) exact match or within 2% tolerance
> b) within 5% tolerance
> This also takes care of corner conditions.
>
> Reported-by: kernel test robot <lkp@intel.com>
Did the test robot really report the original issue, or just the v2
change?
thanks,
greg k-h
next prev parent reply other threads:[~2022-06-30 15:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 10:00 [V2] tty: serial: qcom-geni-serial: Fix get_clk_div_rate() which otherwise could return a sub-optimal clock rate Vijaya Krishna Nivarthi
2022-06-29 13:02 ` kernel test robot
2022-06-29 23:15 ` Doug Anderson
2022-07-01 11:04 ` Vijaya Krishna Nivarthi (Temp) (QUIC)
2022-07-01 15:08 ` Doug Anderson
2022-07-04 18:57 ` Vijaya Krishna Nivarthi (Temp)
2022-07-06 15:26 ` Doug Anderson
2022-07-06 17:43 ` Vijaya Krishna Nivarthi
2022-07-06 18:21 ` Doug Anderson
2022-07-07 19:24 ` Vijaya Krishna Nivarthi
2022-06-30 15:00 ` Greg KH [this message]
2022-06-30 17:19 ` Vijaya Krishna Nivarthi (Temp) (QUIC)
2022-06-30 21:57 ` Doug Anderson
2022-07-04 21:20 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr26oSKOhIBMaKsS@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=jirislaby@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mka@chromium.org \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vnivarth@quicinc.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox