Re: [PATCH v2 1/9] mm: Add msharefs filesystem

Khalid Aziz
2022-07-01T16:09:31Z

On 6/30/22 16:57, Al Viro wrote:
> On Wed, Jun 29, 2022 at 04:53:52PM -0600, Khalid Aziz wrote:
>> +static int
>> +msharefs_d_hash(const struct dentry *dentry, struct qstr *qstr)
>> +{
>> + unsigned long hash = init_name_hash(dentry);
>> + const unsigned char *s = qstr->name;
>> + unsigned int len = qstr->len;
>> +
>> + while (len--)
>> + hash = partial_name_hash(*s++, hash);
>> + qstr->hash = end_name_hash(hash);
>> + return 0;
>> +}
>
> What do you need that for and how is it different from letting it
> use full_name_hash() (which is what it will do if you leave
> dentry_operations->d_hash equal to NULL)?

I don't have a specific reason to use msharefs_d_hash(). If full_name_hash() can work, I don't mind reducing amount of
code in my patch. I will take a look at it.

Thanks,
Khalid