public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Li kunyu <kunyu@nfschina.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, linux-usb@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: usb: Fix typo in code
Date: Fri, 1 Jul 2022 08:19:43 +0200	[thread overview]
Message-ID: <Yr6R/wsl+HlOwOEm@kroah.com> (raw)
In-Reply-To: <20220701020751.3059-1-kunyu@nfschina.com>

On Fri, Jul 01, 2022 at 10:07:51AM +0800, Li kunyu wrote:
> hasdata does not need to be initialized to zero. It will be assigned a
> value in the following judgment conditions.
> Remove the repeated ';' from code.

That is a lot of different things all in the same commit.  Please break
this up into one-change-per-commit like is required.

You also do something in here that you do not document :(

thanks,

greg k-h

  reply	other threads:[~2022-07-01  6:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-01  2:07 [PATCH] net: usb: Fix typo in code Li kunyu
2022-07-01  6:19 ` Greg KH [this message]
2022-07-01  6:47   ` [PATCH v2] " Li kunyu
2022-07-01  6:51     ` Greg KH
2022-07-01 13:00     ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yr6R/wsl+HlOwOEm@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=kunyu@nfschina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox