public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
	syzbot <syzbot+3cc1054e15babd5f4cd2@syzkaller.appspotmail.com>,
	akpm@linux-foundation.org, glider@google.com,
	gregkh@linuxfoundation.org, jirislaby@kernel.org,
	john.ogness@linutronix.de, linux-kernel@vger.kernel.org,
	npiggin@gmail.com, pmladek@suse.com, rdunlap@infradead.org,
	rostedt@goodmis.org, swboyd@chromium.org,
	syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] possible deadlock in console_lock_spinning_enable (2)
Date: Mon, 20 Jun 2022 18:24:15 +0900	[thread overview]
Message-ID: <YrA8vzVjxJIrZFBz@google.com> (raw)
In-Reply-To: <CACT4Y+aFArPDsyvpNko+_eZi=1UTd2NxfejiyawRA0aKScWmJA@mail.gmail.com>

On (22/06/20 10:16), Dmitry Vyukov wrote:
> On Mon, 20 Jun 2022 at 07:44, Sergey Senozhatsky
> <senozhatsky@chromium.org> wrote:
> >
> > On (22/06/18 20:47), syzbot wrote:
> > > syzbot suspects this issue was fixed by commit:
> > >
> > > commit faebd693c59387b7b765fab64b543855e15a91b4
> > > Author: John Ogness <john.ogness@linutronix.de>
> > > Date:   Thu Apr 21 21:22:36 2022 +0000
> > >
> > >     printk: rename cpulock functions
> >
> > I'd rather guess that it was console kthread patch that fixed the problem.
> 
> Hi Sergey,
> 
> Do you mean this commit:
> 
> author: John Ogness 2022-04-21 23:28:48 +0206
> printk: add kthread console printers
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=09c5ba0aa2fcfdadb17d045c3ee6f86d69270df7

Yes, I'd assume so. The patch removes

	tty -> printk -> tty

which re-enters tty in unsafe manner, and replaces it with

	tty -> printk -> wake_up console printer

  reply	other threads:[~2022-06-20  9:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-14 15:58 [syzbot] possible deadlock in console_lock_spinning_enable (2) syzbot
2021-12-10 20:24 ` syzbot
2022-06-19  3:47 ` syzbot
2022-06-20  5:44   ` Sergey Senozhatsky
2022-06-20  8:16     ` Dmitry Vyukov
2022-06-20  9:24       ` Sergey Senozhatsky [this message]
2022-06-20 11:28         ` Dmitry Vyukov
     [not found] <20220619074222.197-1-hdanton@sina.com>
2022-06-19  9:46 ` syzbot
     [not found] <20220619121654.313-1-hdanton@sina.com>
2022-06-19 12:35 ` syzbot
     [not found] <20220619133032.381-1-hdanton@sina.com>
2022-06-19 16:42 ` syzbot
     [not found] <20220620104728.501-1-hdanton@sina.com>
2022-06-20 11:10 ` syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrA8vzVjxJIrZFBz@google.com \
    --to=senozhatsky@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@gmail.com \
    --cc=pmladek@suse.com \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=swboyd@chromium.org \
    --cc=syzbot+3cc1054e15babd5f4cd2@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox