From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 977CFC43334 for ; Mon, 20 Jun 2022 19:53:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241779AbiFTTxC (ORCPT ); Mon, 20 Jun 2022 15:53:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344023AbiFTTww (ORCPT ); Mon, 20 Jun 2022 15:52:52 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64F48396 for ; Mon, 20 Jun 2022 12:52:50 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id w17so16023048wrg.7 for ; Mon, 20 Jun 2022 12:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=jq8IlzmRmUKlqv3On/oY1AUojxYr/sDjB5anz61AADg=; b=BFMp9cD/zJgwL7A4Gi2zq2+syrCaj79o2kHHXPppdxVFrjwtVwLBYpUIDHRY9a26gL s1Feayiw4pBUYQ4FYhfHO5CdknDD+GXwv9ka04CjqdQMwf0vWl+GJdgALEa8a3Ga7dd/ le3DpXKcQEiR1UvDGX2k3gXztiMotyh4G1Njku9pVrPab4aOx/YOnMWZCvnl+uDd4+Rk b/3VHTUWZHW5sX4LtW/816+QZQUlZVjC/MYeLLaDSj49J0+TBTVfQnYNPqgfq/96Gqbc cB7Gc1s57/b2BFq43tGo3oBWLmMNuPsqvYd0IY5jrJEcIpZBzMpUor866y2vaBqhEtwf Xw5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=jq8IlzmRmUKlqv3On/oY1AUojxYr/sDjB5anz61AADg=; b=4B9R+rAF7HbW5uyzL6AKc2wPb+tUfvxn8wCjuVQloZoiqsqSwcpCdABwmRauiAB5Cz rwFY7174hgG+FLlJ1GoTP5h3f5LiXl8C23MqNXstQW/msIWj84dtrMlnHOvlS7FrK48D Rh0B0Tr0gdmcizMkIphOxvJK1POLL41AuAN2j0oAEvx9zNgReBCtX/GBBOLJQmAokSFn cm0RR4XiIpxk02lQdlYlhYgdhjqcVY1asH43loMAtH5Ulm/GyVbLMr36z55Im8lzzmKf j1d7xB4dvkTsle3Zw8i6MIdGrUBRnov7pHVgu0rhklTMOPA90VZ9o0H8avd/g/Va+62/ PIUg== X-Gm-Message-State: AJIora+3fyZmr+fs4b+oCAZR6O1sO90Qc8QfUFT5DMHasnOIfoUW/2vW Xl/JlOFTDkDBfFV86ovJBfue5Q== X-Google-Smtp-Source: AGRyM1ub028C5N2cNunBKzdOO6smSIhTL/+9sSH1BIJD/KahEQc2jTp8WwsgKdqKKhpYSvmh2TlDGA== X-Received: by 2002:a5d:598e:0:b0:218:525b:4743 with SMTP id n14-20020a5d598e000000b00218525b4743mr24392302wri.708.1655754768944; Mon, 20 Jun 2022 12:52:48 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id j19-20020a05600c1c1300b0039c5645c60fsm28023077wms.3.2022.06.20.12.52.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jun 2022 12:52:48 -0700 (PDT) Date: Mon, 20 Jun 2022 21:52:44 +0200 From: LABBE Corentin To: heiko@sntech.de, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, m.reichl@fivetechno.de Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, stable@kernel.org Subject: Re: [PATCH] arm64: rockchip: rk3399-roc-pc: prevent fusb302 powering off the board during boot Message-ID: References: <20220620110407.2393644-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220620110407.2393644-1-clabbe@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le Mon, Jun 20, 2022 at 11:04:07AM +0000, Corentin Labbe a écrit : > The rk3399-roc-pc never finish booting because it is powered off when probing > fusb302. > > The type c port is disabled because not present in DT as can seen in dmesg: > OF: graph: no port node found in /i2c@ff3d0000/usb-typec@22 > > So adding the port in DT (as needed by the device tree schema of > fusb302), permits the board to survive and finish booting. > > CC: stable@kernel.org # 5.10+ > Fixes: 8bb878cf20ae ("arm64: dts: rockchip: add support for ROC-RK3399-PC board") > Signed-off-by: Corentin Labbe > --- > This patch is tested on 5.10.123, 5.15.48 and next-20220614 > Please ignore this for now, it fixes the issue but [ 31.653778] typec_fusb302 7-0022: cannot register tcpm port, ret=-22 [ 31.659415] typec_fusb302: probe of 7-0022 failed with error -22 So while having a board which boot fine is better, having everything well probed will be better. For fixing the probe error, adding the following is sufficiant: @@ -558,6 +559,9 @@ connector { data-role = "host"; label = "USB-C"; power-role = "dual"; + op-sink-microwatt = <1000000>; + sink-pdos = ; + source-pdos = ; ports { #address-cells = <1>; But this bring the initial issue, the board is still dont booting...