From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E3B4C43334 for ; Tue, 21 Jun 2022 14:54:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351939AbiFUOy0 (ORCPT ); Tue, 21 Jun 2022 10:54:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350167AbiFUOyX (ORCPT ); Tue, 21 Jun 2022 10:54:23 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0367E23BFF for ; Tue, 21 Jun 2022 07:54:23 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id o18so5706330plg.2 for ; Tue, 21 Jun 2022 07:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ePpQR91B1wy0uIyvmn3lmteXD4y16fGYbzlfAq99TJo=; b=coFv7I5Y78JhXoxS37XR9c+mZYbk7SXPwuO7aREgBr4Q4xY/8nD/BF5WkQBHENLFnR M2swZ0YHKkbeZ6TusTYTCyinn24BoObIO+T5wnAXl9f2sGVIP8rG2F0nAbxkmCVGoPfH dAA8jbBGQ+fJqAoZJEhloFcXw4ggDv8whrRonPLp5/G9ruQkcs3nglSNUwAkZ1SThAWs 1rcmQq3sdA0WobCN3wZET42yLYirfqnABm0YdtxHceX3EHLEBkMtv0LKHMPI3jgadxxF dsa+Azc2y1bTS9+0PGwluDhQy+WUsYOcrTtvwmmyLjgGWHBJwb4h86H6/giVMU3D/eNI BJew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ePpQR91B1wy0uIyvmn3lmteXD4y16fGYbzlfAq99TJo=; b=s7WjWit5pztth+u1QeSiWTq1/ZBSJ67rC0SkapBLdHan7hw4J9vo1mTyk0KM5IgN1j W+ZWtdAo6+FyL6wVgwEPP+dqroR771N2iyaJ0fnO5g1KwSFAmxyZRBcmearnFY+clxfn TqOEXfRrprCaSAgd9Sxjuud/hQkXSEgcaIovRi2av6LDfOSxs4KjT6GFD6ewwUxEiOPH HlLWKBPHWgDDbvHUmpS4P69kQniehfYL8fBSGU7aq1cPz4GkB0aN1G02huPnAlRAw25b 88J3S2FCRjVHYwchgogHR1+h6KkVSSrowkzMXqUay4UGok4oj3RMmgNpgsIwDlEYnTyH dDBw== X-Gm-Message-State: AJIora+0mnyeTKUWMZsT1KTx018HpUZ+UgeUdIuramPYgZ2V1oBbaY8i vFznURoRn67/6+9W9GfIVtkMIQ== X-Google-Smtp-Source: AGRyM1vbuWPmzs8GSCKmhq+oi4jC8RW6CP9GBVkjErftz4qJu7wc14nAXYcvbe2B5lTWXF3n/kUg1Q== X-Received: by 2002:a17:90b:4a82:b0:1ec:bb6b:38d0 with SMTP id lp2-20020a17090b4a8200b001ecbb6b38d0mr7523665pjb.213.1655823262366; Tue, 21 Jun 2022 07:54:22 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id b21-20020aa78115000000b00518764d09cdsm11307136pfi.164.2022.06.21.07.54.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 07:54:21 -0700 (PDT) Date: Tue, 21 Jun 2022 14:54:18 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: Marc Zyngier , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Colton Lewis , Andrew Jones Subject: Re: [PATCH 0/3] KVM: selftests: Consolidate ucall code Message-ID: References: <20220618001618.1840806-1-seanjc@google.com> <19bba1a0-8fb7-2aae-a65a-1111e29b92d3@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19bba1a0-8fb7-2aae-a65a-1111e29b92d3@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 20, 2022, Paolo Bonzini wrote: > On 6/18/22 02:16, Sean Christopherson wrote: > > Consolidate the code for making and getting ucalls. All architectures pass > > the ucall struct via memory, so filling and copying the struct is 100% > > generic. The only per-arch code is sending and receiving the address of > > said struct. > > > > Tested on x86 and arm, compile tested on s390 and RISC-V. > > I'm not sure about doing this yet. The SEV tests added multiple > implementations of the ucalls in one architecture. I have rebased those > recently (not the SEV part) to get more familiar with the new kvm_vcpu API > for selftests, and was going to look at your old review next... I had forgotten about that code. My idea of a per-VM list[*] would fit nicely on top, though maybe drop the last patch from this series. [*] https://lore.kernel.org/all/Yc4gcJdhxthBKUUd@google.com