From: Johan Hovold <johan@kernel.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] arm64: dts: qcom: add SA8540P and ADP
Date: Wed, 22 Jun 2022 15:44:49 +0200 [thread overview]
Message-ID: <YrMc0Y7PIDQpP2xw@hovoldconsulting.com> (raw)
In-Reply-To: <8fc661d7-6f75-59d8-fa19-76193ed2f4fe@somainline.org>
On Wed, Jun 22, 2022 at 02:37:02PM +0200, Konrad Dybcio wrote:
> On 22.06.2022 06:12, Bjorn Andersson wrote:
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> > @@ -0,0 +1,427 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +/*
> > + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> > + * Copyright (c) 2022, Linaro Limited
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include <dt-bindings/gpio/gpio.h>
> Can be moved to SoC dtsi.
No, the SoC dtsi does not use any defines from that header file.
> > +#include <dt-bindings/input/gpio-keys.h>
> > +#include <dt-bindings/input/input.h>
> > +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> > +#include <dt-bindings/spmi/spmi.h>
> > +
> > +/* PINCTRL */
> Seems redundant.
See my previous answer to this.
Johan
next prev parent reply other threads:[~2022-06-22 13:44 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 4:12 [PATCH v2 0/6] arm64: dts: qcom: Introduce SC8280XP Bjorn Andersson
2022-06-22 4:12 ` [PATCH v2 1/6] dt-bindings: arm: qcom: Document additional sc8280xp devices Bjorn Andersson
2022-06-22 8:47 ` Johan Hovold
2022-06-22 21:06 ` Bjorn Andersson
2022-06-22 14:05 ` Krzysztof Kozlowski
2022-06-22 4:12 ` [PATCH v2 2/6] dt-bindings: mailbox: qcom-ipcc: Add NSP1 client Bjorn Andersson
2022-06-22 4:12 ` [PATCH v2 3/6] arm64: dts: qcom: add SC8280XP platform Bjorn Andersson
2022-06-22 8:53 ` Johan Hovold
2022-06-22 12:27 ` Konrad Dybcio
2022-06-22 14:07 ` Krzysztof Kozlowski
2022-06-22 18:56 ` Stephan Gerhold
2022-06-22 19:41 ` Bjorn Andersson
2022-06-22 4:12 ` [PATCH v2 4/6] arm64: dts: qcom: sc8280xp: Add reference device Bjorn Andersson
2022-06-22 9:06 ` Johan Hovold
2022-06-22 12:33 ` Konrad Dybcio
2022-06-22 13:43 ` Johan Hovold
2022-06-22 14:36 ` Konrad Dybcio
2022-06-22 14:44 ` Johan Hovold
2022-06-22 14:48 ` Krzysztof Kozlowski
2022-06-22 15:10 ` Konrad Dybcio
2022-06-22 15:26 ` Johan Hovold
2022-06-22 15:30 ` Konrad Dybcio
2022-06-22 15:37 ` Johan Hovold
2022-06-22 15:39 ` Konrad Dybcio
2022-06-22 21:00 ` Bjorn Andersson
2022-06-22 13:09 ` Johan Hovold
2022-06-22 4:12 ` [PATCH v2 5/6] arm64: dts: qcom: add SA8540P and ADP Bjorn Andersson
2022-06-22 9:24 ` Johan Hovold
2022-06-22 12:37 ` Konrad Dybcio
2022-06-22 13:44 ` Johan Hovold [this message]
2022-06-22 14:11 ` Krzysztof Kozlowski
2022-06-22 14:15 ` Johan Hovold
2022-06-22 13:11 ` Johan Hovold
2022-06-22 4:12 ` [PATCH v2 6/6] arm64: dts: qcom: sc8280xp: add Lenovo Thinkpad X13s devicetree Bjorn Andersson
2022-06-22 12:39 ` Konrad Dybcio
2022-06-22 13:49 ` Johan Hovold
2022-06-22 13:14 ` Johan Hovold
2022-06-22 13:26 ` [PATCH v3] " Johan Hovold
2022-06-22 14:18 ` Krzysztof Kozlowski
2022-06-27 11:38 ` Konrad Dybcio
2022-06-28 8:00 ` Johan Hovold
2022-06-28 8:09 ` Konrad Dybcio
2022-06-28 8:14 ` Johan Hovold
2022-06-28 8:19 ` Krzysztof Kozlowski
2022-07-03 3:56 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrMc0Y7PIDQpP2xw@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox