From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B535FC43334 for ; Thu, 23 Jun 2022 03:03:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229981AbiFWDCr (ORCPT ); Wed, 22 Jun 2022 23:02:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230164AbiFWC77 (ORCPT ); Wed, 22 Jun 2022 22:59:59 -0400 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80C09DE0; Wed, 22 Jun 2022 19:59:58 -0700 (PDT) Date: Wed, 22 Jun 2022 19:59:51 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1655953196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YnvK7aerQUa0omlszHP+BCpalfo/qLZX0q6ERiQbLTM=; b=eMHDZN3IqCwtLkJtKTi1NkzWsPvkp7RbT7dj9sbpVLAt7BxvVLRu27tlMujGL3dukHN/aq TBoi6VPsOkfifOzjqlfQi8krUNGeECskF4eMgEmZ0j+Qj6EaMysWdqNRvVTmiX8zctg31s k7pcqDBZfMTKMS+4AuqQnSoapZZdu8Q= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Muchun Song Cc: syzbot , akpm@linux-foundation.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, shakeelb@google.com, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] WARNING in folio_lruvec_lock_irqsave Message-ID: References: <0000000000004b03c805e2099bf0@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 23, 2022 at 10:32:32AM +0800, Muchun Song wrote: > On Wed, Jun 22, 2022 at 11:33:48PM +0800, Muchun Song wrote: > > On Wed, Jun 22, 2022 at 06:49:31AM -0700, syzbot wrote: > > > Hello, > > > > > > syzbot found the following issue on: > > > > > > HEAD commit: ac0ba5454ca8 Add linux-next specific files for 20220622 > > > git tree: linux-next > > > console output: https://syzkaller.appspot.com/x/log.txt?x=14354c18080000 > > > kernel config: https://syzkaller.appspot.com/x/.config?x=12809dacb9e7c5e0 > > > dashboard link: https://syzkaller.appspot.com/bug?extid=ec972d37869318fc3ffb > > > compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 > > > > > > Unfortunately, I don't have any reproducer for this issue yet. > > > > > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > > > Reported-by: syzbot+ec972d37869318fc3ffb@syzkaller.appspotmail.com > > > > > > folio_put include/linux/mm.h:1227 [inline] > > > put_page+0x217/0x280 include/linux/mm.h:1279 > > > unmap_and_move_huge_page mm/migrate.c:1343 [inline] > > > migrate_pages+0x3dc3/0x5a10 mm/migrate.c:1440 > > > do_mbind mm/mempolicy.c:1332 [inline] > > > kernel_mbind+0x4d7/0x7d0 mm/mempolicy.c:1479 > > > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > > > do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 > > > entry_SYSCALL_64_after_hwframe+0x46/0xb0 > > > page has been migrated, last migrate reason: mempolicy_mbind > > > ------------[ cut here ]------------ > > > WARNING: CPU: 1 PID: 18925 at include/linux/memcontrol.h:800 folio_lruvec include/linux/memcontrol.h:800 [inline] > > > > The warning here is "VM_WARN_ON_ONCE_FOLIO(!memcg && !mem_cgroup_disabled(), folio)", > > the memcg returned by folio_memcg() seems to be NULL which has 2 possibility, one is > > that objcg returned by folio_objcg() is NULL, another is that obj_cgroup_memcg(objcg) > > returns NULL. However, obj_cgroup_memcg() always returns a valid memcg. So Most likely > > objcg is NULL meaning this page is not charged to memcg. Is this possible for LRU pages? > > > > I am not sure if this issue is caused by my commit cca700a8e695 ("mm: lru: use lruvec > > I have asked Andrew to drop this individual commit (to reduce potential impact) since > this commit can be treated as a separate optimization patch compared to LRU page > reparenting work. I will resend this patch again after LRU page reparenting work > stabilizes. Sorry, I haven't noticed this e-mail and suggested the same. Sounds like a good idea to me.