From: Andrew Lunn <andrew@lunn.ch>
To: Enguerrand de Ribaucourt
<enguerrand.de-ribaucourt@savoirfairelinux.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
hkallweit1@gmail.com
Subject: Re: [PATCH v3 1/2] net: dp83822: disable false carrier interrupt
Date: Thu, 23 Jun 2022 20:27:12 +0200 [thread overview]
Message-ID: <YrSwgKpa+KUxIZd5@lunn.ch> (raw)
In-Reply-To: <20220623134645.1858361-2-enguerrand.de-ribaucourt@savoirfairelinux.com>
On Thu, Jun 23, 2022 at 03:46:44PM +0200, Enguerrand de Ribaucourt wrote:
> When unplugging an Ethernet cable, false carrier events were produced by
> the PHY at a very high rate. Once the false carrier counter full, an
> interrupt was triggered every few clock cycles until the cable was
> replugged. This resulted in approximately 10k/s interrupts.
>
> Since the false carrier counter (FCSCR) is never used, we can safely
> disable this interrupt.
>
> In addition to improving performance, this also solved MDIO read
> timeouts I was randomly encountering with an i.MX8 fec MAC because of
> the interrupt flood. The interrupt count and MDIO timeout fix were
> tested on a v5.4.110 kernel.
>
> Signed-off-by: Enguerrand de Ribaucourt <enguerrand.de-ribaucourt@savoirfairelinux.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission")
For future reference, you should put these in the opposite order. Your
Signed-off-by should come last. Fixes generally comes first.
No need to resend for this patchset.
Andrew
next prev parent reply other threads:[~2022-06-23 19:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 13:46 [PATCH] net: dp83822: disable false carrier interrupt Enguerrand de Ribaucourt
2022-06-17 17:55 ` Andrew Lunn
2022-06-23 8:51 ` Enguerrand de Ribaucourt
2022-06-23 8:51 ` [PATCH 1/2] " Enguerrand de Ribaucourt
2022-06-23 12:42 ` Andrew Lunn
2022-06-23 13:16 ` Enguerrand de Ribaucourt
2022-06-23 8:51 ` [PATCH 2/2] net: dp83822: disable rx error interrupt Enguerrand de Ribaucourt
2022-06-23 13:06 ` [PATCH v2 0/2] net: dp83822: fix interrupt floods Enguerrand de Ribaucourt
2022-06-23 13:06 ` [PATCH v2 1/2] net: dp83822: disable false carrier interrupt Enguerrand de Ribaucourt
2022-06-23 13:06 ` [PATCH v2 2/2] net: dp83822: disable rx error interrupt Enguerrand de Ribaucourt
2022-06-23 13:14 ` [PATCH v2 0/2] net: dp83822: fix interrupt floods Enguerrand de Ribaucourt
2022-06-23 13:14 ` [PATCH v2 1/2] net: dp83822: disable false carrier interrupt Enguerrand de Ribaucourt
2022-06-23 13:14 ` [PATCH v2 2/2] net: dp83822: disable rx error interrupt Enguerrand de Ribaucourt
2022-06-23 13:46 ` [PATCH v3 0/2] net: dp83822: fix interrupt floods Enguerrand de Ribaucourt
2022-06-23 13:46 ` [PATCH v3 1/2] net: dp83822: disable false carrier interrupt Enguerrand de Ribaucourt
2022-06-23 18:27 ` Andrew Lunn [this message]
2022-06-23 13:46 ` [PATCH v3 2/2] net: dp83822: disable rx error interrupt Enguerrand de Ribaucourt
2022-06-23 18:24 ` [PATCH v3 0/2] net: dp83822: fix interrupt floods Andrew Lunn
2022-06-24 23:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrSwgKpa+KUxIZd5@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=enguerrand.de-ribaucourt@savoirfairelinux.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox