From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FFD2C433EF for ; Fri, 24 Jun 2022 04:27:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229621AbiFXE1f (ORCPT ); Fri, 24 Jun 2022 00:27:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbiFXE1e (ORCPT ); Fri, 24 Jun 2022 00:27:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B268D6808C for ; Thu, 23 Jun 2022 21:27:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 468A9620E3 for ; Fri, 24 Jun 2022 04:27:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC198C34114; Fri, 24 Jun 2022 04:27:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656044852; bh=V15RsvX1+kM5FL7HzYFUlsvJt53ggBmFiKd/GuXmjCs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NmvU82paGPiRMAiacFz4FNJVJxeI1JbNtw1jbHoW5e3CVlH8tpmUdd6lv5BSwcdM1 v4uL9Z7gi4ooLx2Ipm3aBWYTsPLztS/myXB1ropefpunTGcqBnKgapgHR8Z7qNpNlm CtAWngEOk9V9dqcka22jrMTwBN35I0NbNLic/7xIH46rzszA/U65ddirNeJx92VHb4 /F28tF9VLYMqgi/oZAwrTyK4Tk/CN5emI9bQkR3X7AoHtWD5GIAt7+F7/aE2Bxtxt0 /wQ8RzJWkoUSdHAEjCp57j6a422udJVCSevxb2JaSHjkTYDn7TLqN9dkFAUjOM+gkV OxLqHRgK6hALw== Date: Fri, 24 Jun 2022 09:57:28 +0530 From: Vinod Koul To: Bard Liao Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, gregkh@linuxfoundation.org, srinivas.kandagatla@linaro.org, pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com, bard.liao@intel.com, peter.ujfalusi@linux.intel.com, ranjani.sridharan@linux.intel.com Subject: Re: [PATCH v2 1/2] soundwire: Intel: add trigger callback Message-ID: References: <20220616011758.21155-1-yung-chuan.liao@linux.intel.com> <20220616011758.21155-2-yung-chuan.liao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220616011758.21155-2-yung-chuan.liao@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16-06-22, 09:17, Bard Liao wrote: > When a pipeline is split into FE and BE parts, the BE pipeline may need to > be triggered separately in the BE trigger op. So add the trigger callback > in the link_res ops that will be invoked during BE DAI trigger. > > Signed-off-by: Bard Liao > Reviewed-by: Rander Wang > Reviewed-by: Pierre-Louis Bossart > Reviewed-by: Ranjani Sridharan > --- > drivers/soundwire/intel.c | 8 ++++++++ > include/linux/soundwire/sdw_intel.h | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c > index 505c5ef061e3..2e7c27d303b4 100644 > --- a/drivers/soundwire/intel.c > +++ b/drivers/soundwire/intel.c > @@ -1004,9 +1004,17 @@ static int intel_trigger(struct snd_pcm_substream *substream, int cmd, struct sn > { > struct sdw_cdns *cdns = snd_soc_dai_get_drvdata(dai); > struct sdw_intel *sdw = cdns_to_intel(cdns); > + struct sdw_intel_link_res *res = sdw->link_res; > struct sdw_cdns_dma_data *dma; > int ret = 0; > > + /* The .trigger callback is used to send required IPC to audio > + * firmware. The .free_stream callback will still be called > + * by intel_free_stream() in the TRIGGER_SUSPEND case. > + */ we dont use this style multi-line comment, pls fix it to: /* * The .trigger callback is used to send required IPC to .. * ... */ with that fixed: Acked-By: Vinod Koul > + if (res->ops && res->ops->trigger) > + res->ops->trigger(dai, cmd, substream->stream); > + > dma = snd_soc_dai_get_dma_data(dai, substream); > if (!dma) { > dev_err(dai->dev, "failed to get dma data in %s\n", > diff --git a/include/linux/soundwire/sdw_intel.h b/include/linux/soundwire/sdw_intel.h > index b5b489ea1aef..ec16ae49e6a4 100644 > --- a/include/linux/soundwire/sdw_intel.h > +++ b/include/linux/soundwire/sdw_intel.h > @@ -121,6 +121,7 @@ struct sdw_intel_ops { > struct sdw_intel_stream_params_data *params_data); > int (*free_stream)(struct device *dev, > struct sdw_intel_stream_free_data *free_data); > + int (*trigger)(struct snd_soc_dai *dai, int cmd, int stream); > }; > > /** > -- > 2.17.1 -- ~Vinod