From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] drm: Remove unnecessary print function dev_err()
Date: Fri, 24 Jun 2022 17:00:54 +0200 [thread overview]
Message-ID: <YrXRplhnlUZ2KV3V@aptenodytes> (raw)
In-Reply-To: <20220613012658.85814-1-yang.lee@linux.alibaba.com>
[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]
Hi Yang,
On Mon 13 Jun 22, 09:26, Yang Li wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/gpu/drm/logicvc/logicvc_drm.c:352:2-9: line 352 is redundant
> because platform_get_irq() already prints an error
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Thanks for the patch!
Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Paul
> ---
> drivers/gpu/drm/logicvc/logicvc_drm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logicvc/logicvc_drm.c
> index df1805cf0f95..437b3011ae1e 100644
> --- a/drivers/gpu/drm/logicvc/logicvc_drm.c
> +++ b/drivers/gpu/drm/logicvc/logicvc_drm.c
> @@ -349,7 +349,6 @@ static int logicvc_drm_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(dev, "Failed to get IRQ\n");
> ret = -ENODEV;
> goto error_reserved_mem;
> }
> --
> 2.20.1.7.g153144c
>
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-06-24 15:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 1:26 [PATCH -next] drm: Remove unnecessary print function dev_err() Yang Li
2022-06-24 15:00 ` Paul Kocialkowski [this message]
2022-06-24 15:26 ` Paul Kocialkowski
-- strict thread matches above, loose matches on Subject: below --
2022-06-24 0:50 Yang Li
2022-06-26 3:46 ` Orson Zhai
2022-07-07 1:47 Yang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrXRplhnlUZ2KV3V@aptenodytes \
--to=paul.kocialkowski@bootlin.com \
--cc=abaci@linux.alibaba.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox