From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 726A6CCA479 for ; Sat, 25 Jun 2022 08:15:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232147AbiFYIP4 (ORCPT ); Sat, 25 Jun 2022 04:15:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231752AbiFYIPz (ORCPT ); Sat, 25 Jun 2022 04:15:55 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 200A33136A for ; Sat, 25 Jun 2022 01:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=Pgxk4GfqdEazMAaUU8Vogm2IvjJW if2mBoFjn2TkMjk=; b=Nf+lUCla94gyxk8LVQxRbj9mYLSCbDmDWziQGqiEJWUx Xvi6U2bnZGYMyHW3ugkYNa9KaHaYbDloZj/Ijh4tSbltdUBe7NLEy3fqCiEfe8CD myzROIqI2UYIuJaU2WKPcwWe/YsU4puPWSPtJsSIdhWD2ICCXJBJmMF1EQgr5zM= Received: (qmail 1730323 invoked from network); 25 Jun 2022 10:15:48 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 25 Jun 2022 10:15:48 +0200 X-UD-Smtp-Session: l3s3148p1@9S9VS0HizZgucq2i Date: Sat, 25 Jun 2022 10:15:47 +0200 From: Wolfram Sang To: Lad Prabhakar Cc: Ulf Hansson , Philipp Zabel , Yoshihiro Shimoda , Geert Uytterhoeven , Pavel Machek , linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das Subject: Re: [PATCH v3 1/2] mmc: renesas_sdhi: Get the reset handle early in the probe Message-ID: Mail-Followup-To: Wolfram Sang , Lad Prabhakar , Ulf Hansson , Philipp Zabel , Yoshihiro Shimoda , Geert Uytterhoeven , Pavel Machek , linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das References: <20220624181438.4355-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20220624181438.4355-2-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uukWhCvGKCjJxTsP" Content-Disposition: inline In-Reply-To: <20220624181438.4355-2-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --uukWhCvGKCjJxTsP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 24, 2022 at 07:14:37PM +0100, Lad Prabhakar wrote: > In case of devm_reset_control_get_optional_exclusive() failure we returned > directly instead of jumping to the error path to roll back initialization. >=20 > This patch moves devm_reset_control_get_optional_exclusive() early in the > probe so that we have the reset handle prior to initialization of the > hardware. >=20 > Fixes: b4d86f37eacb7 ("mmc: renesas_sdhi: do hard reset if possible") > Reported-by: Pavel Machek > Signed-off-by: Lad Prabhakar > Reviewed-by: Geert Uytterhoeven Reviewed-by: Wolfram Sang --uukWhCvGKCjJxTsP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmK2xDMACgkQFA3kzBSg KbZ6vw//dYXe8UJWJ4MK6BZEyBiOHEgwHi/XvYWgWd7XgvHGqEbxS/zHZfkp7sjH CBm7q7lDmwoNpcyNIWxeTYalAnTMMLSjNu7aV112qc58Bj6DmyuvHvP0kN+eD8dP wyTGXkW4hEhLvAuHWhocPoS1iQ9IHiOCOqS9vyO7ClKkEKJIflbJqI1RCeUc4BVS C3WAmfLFtorwQGt44IQJ7NteAcpxbwF+o4oG59o86DkdscbHlQNxEEJDnAqPz8Cb 3rVkO7g1NnF3NsO4ko2uFEoyMa5z1lkkvGIztdLHczg6nDUIWtjpqAC1/tzbK8u2 emgJfmKpULEivIMt1TBSpRAdJHK0gqt5Q4IuZzy4R3VQjOkaODqoEVwPiRYBf5qU 34QaH31pbHbqqKk8X3b98J5jZXr17KsguZMYUXHb4ivl/kFHH8U1rMhppSdIK0to VRNarMDkOkQG31vWyjYhydHRzNlyXTdnqUoQ38MP5eTbJSge3GapAvK02ilA5VJG KipMmBmWh3jDoLPYBqEIXfbRbk071HDqsP15CySUDQgS+dTDjSqFLf27qsjMy8xe bqifTDsBZGrjsxrw7ztCiJCwbIJ7zQJanHghAMsfje3I42WLGRpc8fgfz8uBijnp mnXAInO8quyuOiWRLEq+PqVrJNOMOZZYB+jLj492RttIDQnOPog= =TIva -----END PGP SIGNATURE----- --uukWhCvGKCjJxTsP--