From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B44CC433EF for ; Mon, 27 Jun 2022 14:02:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236570AbiF0OC0 (ORCPT ); Mon, 27 Jun 2022 10:02:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236355AbiF0OCW (ORCPT ); Mon, 27 Jun 2022 10:02:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2911510FE9 for ; Mon, 27 Jun 2022 07:02:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C2D5E60B07 for ; Mon, 27 Jun 2022 14:02:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99C8EC3411D; Mon, 27 Jun 2022 14:02:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656338540; bh=HqnmPX+RaZcEbcpHB4WxJc5NFbPDlcVOD2QtlPCs1y4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MQdQRWz5BH7+IVRd9T80YU9QXYDjBVXCpHz8CZUniE8RIkpDlvFubjXjXTBBlBq8S QngpxqYpgopry8LqEE/m0GQ3q4xIMls8QMfKh7VlDb49Hhi37N2hAjPxH5w8MI752c ENxHHrPDgxjnR2aMdrHu1jyug1ZbqZ887IQoWoVQ= Date: Mon, 27 Jun 2022 16:02:17 +0200 From: Greg Kroah-Hartman To: Alexander Usyskin Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Tvrtko Ursulin , Tomas Winkler , Vitaly Lubart , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 13/14] mei: debugfs: add pxp mode to devstate in debugfs Message-ID: References: <20220619133721.523546-1-alexander.usyskin@intel.com> <20220619133721.523546-14-alexander.usyskin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220619133721.523546-14-alexander.usyskin@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 19, 2022 at 04:37:20PM +0300, Alexander Usyskin wrote: > From: Tomas Winkler > > CC: Vitaly Lubart > Signed-off-by: Tomas Winkler We can not take patches without any changelog text, you know this :( > --- > drivers/misc/mei/debugfs.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c > index 1ce61e9e24fc..4074fec866a6 100644 > --- a/drivers/misc/mei/debugfs.c > +++ b/drivers/misc/mei/debugfs.c > @@ -86,6 +86,20 @@ static int mei_dbgfs_active_show(struct seq_file *m, void *unused) > } > DEFINE_SHOW_ATTRIBUTE(mei_dbgfs_active); > > +static const char *mei_dev_pxp_mode_str(enum mei_dev_pxp_mode state) > +{ > +#define MEI_PXP_MODE(state) case MEI_DEV_PXP_##state: return #state > + switch (state) { > + MEI_PXP_MODE(DEFAULT); > + MEI_PXP_MODE(INIT); > + MEI_PXP_MODE(SETUP); > + MEI_PXP_MODE(READY); Just spell out the case and return lines, don't create macros for no good reason please. thanks, greg k-h