From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3D9EC43334 for ; Mon, 27 Jun 2022 23:16:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240887AbiF0XQ2 (ORCPT ); Mon, 27 Jun 2022 19:16:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241007AbiF0XQN (ORCPT ); Mon, 27 Jun 2022 19:16:13 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 274122314B; Mon, 27 Jun 2022 16:16:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 79F51B818E7; Mon, 27 Jun 2022 23:16:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6F1EC34115; Mon, 27 Jun 2022 23:16:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656371765; bh=ZZxR+OcIIP15LVMw2BAXLSLMD60yYs8E8Q4+wsYIO4w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XajuzfuWiIfcsbh3IjCIoM307Q+UKJEC9KBc020DlCcH2wFSjol4qYB1KJ8/QVTJP XTLWiY1CZ8GypkwTk4tIoBn4tqy2L61/xPS7eBhGq0yAfuNB6EnMzMHvXL+glbGapa WoJ8HQeuMOU8i03SgkVr5nBSSHbtxwkcaTXsGWd5w1Qo2B6a1/vzDMUwNpcWCddmlC eKfrbPBw0tOtnPa941W9OAz+vgVojKN6s+Tog1/GgzulZGcCQpwc7/9TzmgUnstkXC rNRskplrnhAE5Y4m0QZ+FGAwXxzZNLSImHpYXC46oOL2huU7szpN9im1VMBvKfUfSh Coj4fotyAVxWw== Date: Tue, 28 Jun 2022 02:16:01 +0300 From: Jarkko Sakkinen To: Tianjia Zhang Cc: David Howells , David Woodhouse , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 RESEND] sign-file: Fix confusing error messages Message-ID: References: <20220627092107.20994-1-tianjia.zhang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220627092107.20994-1-tianjia.zhang@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 27, 2022 at 05:21:07PM +0800, Tianjia Zhang wrote: > When an error occurs, use errx() instead of err() to display the > error message, because openssl has its own error record. When an > error occurs, errno will not be changed, while err() displays the > errno error message. It will cause confusion. For example, when > CMS_add1_signer() fails, the following message will appear: > > sign-file: CMS_add1_signer: Success > > errx() ignores errno and does not cause such issue. > > Signed-off-by: Tianjia Zhang > --- > scripts/sign-file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/sign-file.c b/scripts/sign-file.c > index 7434e9ea926e..598ef5465f82 100644 > --- a/scripts/sign-file.c > +++ b/scripts/sign-file.c > @@ -114,7 +114,7 @@ static void drain_openssl_errors(void) > bool __cond = (cond); \ > display_openssl_errors(__LINE__); \ > if (__cond) { \ > - err(1, fmt, ## __VA_ARGS__); \ > + errx(1, fmt, ## __VA_ARGS__); \ > } \ > } while(0) > > -- > 2.24.3 (Apple Git-128) > Reviewed-by: Jarkko Sakkinen BR, Jarkko