* [PATCH v2 RESEND] sign-file: Fix confusing error messages
@ 2022-06-27 9:21 Tianjia Zhang
2022-06-27 23:16 ` Jarkko Sakkinen
0 siblings, 1 reply; 2+ messages in thread
From: Tianjia Zhang @ 2022-06-27 9:21 UTC (permalink / raw)
To: Jarkko Sakkinen, David Howells, David Woodhouse, keyrings,
linux-kernel
Cc: Tianjia Zhang
When an error occurs, use errx() instead of err() to display the
error message, because openssl has its own error record. When an
error occurs, errno will not be changed, while err() displays the
errno error message. It will cause confusion. For example, when
CMS_add1_signer() fails, the following message will appear:
sign-file: CMS_add1_signer: Success
errx() ignores errno and does not cause such issue.
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
---
scripts/sign-file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/sign-file.c b/scripts/sign-file.c
index 7434e9ea926e..598ef5465f82 100644
--- a/scripts/sign-file.c
+++ b/scripts/sign-file.c
@@ -114,7 +114,7 @@ static void drain_openssl_errors(void)
bool __cond = (cond); \
display_openssl_errors(__LINE__); \
if (__cond) { \
- err(1, fmt, ## __VA_ARGS__); \
+ errx(1, fmt, ## __VA_ARGS__); \
} \
} while(0)
--
2.24.3 (Apple Git-128)
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2 RESEND] sign-file: Fix confusing error messages
2022-06-27 9:21 [PATCH v2 RESEND] sign-file: Fix confusing error messages Tianjia Zhang
@ 2022-06-27 23:16 ` Jarkko Sakkinen
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2022-06-27 23:16 UTC (permalink / raw)
To: Tianjia Zhang; +Cc: David Howells, David Woodhouse, keyrings, linux-kernel
On Mon, Jun 27, 2022 at 05:21:07PM +0800, Tianjia Zhang wrote:
> When an error occurs, use errx() instead of err() to display the
> error message, because openssl has its own error record. When an
> error occurs, errno will not be changed, while err() displays the
> errno error message. It will cause confusion. For example, when
> CMS_add1_signer() fails, the following message will appear:
>
> sign-file: CMS_add1_signer: Success
>
> errx() ignores errno and does not cause such issue.
>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> ---
> scripts/sign-file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/sign-file.c b/scripts/sign-file.c
> index 7434e9ea926e..598ef5465f82 100644
> --- a/scripts/sign-file.c
> +++ b/scripts/sign-file.c
> @@ -114,7 +114,7 @@ static void drain_openssl_errors(void)
> bool __cond = (cond); \
> display_openssl_errors(__LINE__); \
> if (__cond) { \
> - err(1, fmt, ## __VA_ARGS__); \
> + errx(1, fmt, ## __VA_ARGS__); \
> } \
> } while(0)
>
> --
> 2.24.3 (Apple Git-128)
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-27 23:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-27 9:21 [PATCH v2 RESEND] sign-file: Fix confusing error messages Tianjia Zhang
2022-06-27 23:16 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox