From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9634C43334 for ; Tue, 28 Jun 2022 04:38:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238993AbiF1Eiz (ORCPT ); Tue, 28 Jun 2022 00:38:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230241AbiF1Eiv (ORCPT ); Tue, 28 Jun 2022 00:38:51 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BE9D73B5; Mon, 27 Jun 2022 21:38:50 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 6517B81BC; Tue, 28 Jun 2022 04:33:38 +0000 (UTC) Date: Tue, 28 Jun 2022 07:38:49 +0300 From: Tony Lindgren To: Liang He Cc: linux@armlinux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm: mach-omap2: omap4-common: Fix refcount leak bug Message-ID: References: <20220617035548.4003393-1-windhl@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220617035548.4003393-1-windhl@126.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Liang He [220617 06:51]: > In omap4_sram_init(), of_find_compatible_node() will return a node > pointer with refcount incremented. We should use of_node_put() when > it is not used anymore. > > Signed-off-by: Liang He > --- > arch/arm/mach-omap2/omap4-common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c > index 6d1eb4eefefe..e981bf57e64f 100644 > --- a/arch/arm/mach-omap2/omap4-common.c > +++ b/arch/arm/mach-omap2/omap4-common.c > @@ -135,6 +135,7 @@ static int __init omap4_sram_init(void) > pr_warn("%s:Unable to allocate sram needed to handle errata I688\n", > __func__); > sram_pool = of_gen_pool_get(np, "sram", 0); > + of_node_put(np); > if (!sram_pool) > pr_warn("%s:Unable to get sram pool needed to handle errata I688\n", > __func__); Here too sram_pool is used aftger of_node_put(). Regards, Tony