From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michael Walle <michael@walle.cc>
Cc: Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Jiri Slaby <jirislaby@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v2] earlycon: prevent multiple register_console()
Date: Tue, 28 Jun 2022 13:55:33 +0200 [thread overview]
Message-ID: <YrrsNSI4+Gbjt9bm@kroah.com> (raw)
In-Reply-To: <2386f29173c6a6d31e3e07630a44eafb@walle.cc>
On Tue, Jun 28, 2022 at 01:21:23PM +0200, Michael Walle wrote:
> Hi,
>
> Am 2022-06-02 11:00, schrieb Michael Walle:
> > If the earlycon parameter is given twice, the kernel will spit out a
> > WARN() in register_console() because it was already registered. The
> > non-dt variant setup_earlycon() already handles that gracefully. The dt
> > variant of_setup_earlycon() doesn't. Add the check there and add the
> > -EALREADY handling in early_init_dt_scan_chosen_stdout().
> >
> > FWIW, this doesn't happen if CONFIG_ACPI_SPCR_TABLE is set. In that case
> > the registration is delayed until after earlycon parameter(s) are
> > parsed.
> >
> > Signed-off-by: Michael Walle <michael@walle.cc>
>
> Ping :) Or do I have to resend this patch?
I do not see it in my queue anywhere.
prev parent reply other threads:[~2022-06-28 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 9:00 [PATCH v2] earlycon: prevent multiple register_console() Michael Walle
2022-06-02 14:29 ` Rob Herring
2022-06-28 11:21 ` Michael Walle
2022-06-28 11:55 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrrsNSI4+Gbjt9bm@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox