From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2E88CCA480 for ; Wed, 29 Jun 2022 02:31:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229780AbiF2Cb1 (ORCPT ); Tue, 28 Jun 2022 22:31:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229455AbiF2Cb0 (ORCPT ); Tue, 28 Jun 2022 22:31:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8494222522; Tue, 28 Jun 2022 19:31:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 381F3B8215C; Wed, 29 Jun 2022 02:31:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82997C341C8; Wed, 29 Jun 2022 02:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656469882; bh=8xAZ1IIARVTDyCD9gQ3J+dnK+nplzK9hhcBYQq3dJso=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JIG4L/+xrHqRiy/MUVcGNGkv2caMyzZ5XC8C1GwcWkkitSZPlFlNf6+cArmyKSLAU YcLNgnX7hZXTWE5yh0iFcsnLr7iJdA/90H5U/kUcj/f0xauRLCq2/7mkeDNRLDdAH/ W+ha45Qsc6x8tJuif0GuUU2QzgguFDyLtJBiEsa1+m8a1alyDE6Y7JB3t+O4GWtO1l f/uhTmS/qbcoNirk/+dN8ZQuoBKAWyQw74UvgA+p5yva4R3kKSq5w2TU8PAKT+CsTa d08Gq3gpx+Ro5UpzscnSPrz6z7KKG4owYCu8Ats5uQCW+AX6iU9iAvJj5tc7mqyje4 BQRrbXJnUTbeA== Date: Wed, 29 Jun 2022 05:31:19 +0300 From: Jarkko Sakkinen To: Tianjia Zhang Cc: David Howells , Herbert Xu , "David S. Miller" , Elvira Khabirova , Vitaly Chikunov , Stefan Berger , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2 RESEND] pkcs7: support EC-RDSA/streebog in SignerInfo Message-ID: References: <20220627092142.21095-1-tianjia.zhang@linux.alibaba.com> <20220627092142.21095-3-tianjia.zhang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220627092142.21095-3-tianjia.zhang@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 27, 2022 at 05:21:42PM +0800, Tianjia Zhang wrote: > From: Elvira Khabirova > > Allow using EC-RDSA/streebog in pkcs7 certificates in a similar way > to how it's done in the x509 parser. > > This is needed e.g. for loading kernel modules signed with EC-RDSA. > > Signed-off-by: Elvira Khabirova > Reviewed-by: Vitaly Chikunov > Reviewed-by: Tianjia Zhang > --- > crypto/asymmetric_keys/pkcs7_parser.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/crypto/asymmetric_keys/pkcs7_parser.c b/crypto/asymmetric_keys/pkcs7_parser.c > index 24e2e4a6d842..277482bb1777 100644 > --- a/crypto/asymmetric_keys/pkcs7_parser.c > +++ b/crypto/asymmetric_keys/pkcs7_parser.c > @@ -251,6 +251,12 @@ int pkcs7_sig_note_digest_algo(void *context, size_t hdrlen, > case OID_sm3: > ctx->sinfo->sig->hash_algo = "sm3"; > break; > + case OID_gost2012Digest256: > + ctx->sinfo->sig->hash_algo = "streebog256"; > + break; > + case OID_gost2012Digest512: > + ctx->sinfo->sig->hash_algo = "streebog512"; > + break; > default: > printk("Unsupported digest algo: %u\n", ctx->last_oid); > return -ENOPKG; > @@ -284,6 +290,11 @@ int pkcs7_sig_note_pkey_algo(void *context, size_t hdrlen, > ctx->sinfo->sig->pkey_algo = "sm2"; > ctx->sinfo->sig->encoding = "raw"; > break; > + case OID_gost2012PKey256: > + case OID_gost2012PKey512: > + ctx->sinfo->sig->pkey_algo = "ecrdsa"; > + ctx->sinfo->sig->encoding = "raw"; > + break; > default: > printk("Unsupported pkey algo: %u\n", ctx->last_oid); > return -ENOPKG; > -- > 2.24.3 (Apple Git-128) > Please, check: git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git BR, Jarkko