From: Gabriel Viso Carrera <gabriel@gvisoc.com>
To: Joe Perches <joe@perches.com>
Cc: andreas.noever@gmail.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: Thunderbolt: ctl.c: Fixed comment coding style issues
Date: Wed, 29 Jun 2022 16:54:53 +1000 [thread overview]
Message-ID: <Yrv3PTCgzZGu3l8j@vao> (raw)
In-Reply-To: <1a35d3bdf6adde4f21e7c1401f3a2aba64367eb0.camel@perches.com>
On Sat, Jun 25, 2022 at 02:37:54AM -0700, Joe Perches wrote:
[]
>
> I'd indent this only 1 level and put it before the call
> (and fix the loose/lose typo)
>
> {
> /* We ignore failures during stop.
> * All rx packets are referenced from ctl->rx_packets,
> * so we do not lose them.
> */
> tb_ring_rx(pkg->ctl->rx, &pkg->frame);
> }
>
Fair enough. Not sure on how to proceed, as these were my
first patches ever sent, and I don't want to make anyone
work more than the strictly necessary.
- Should I submit an additional patch intended to be applied
on top of 3/3?
- Should I sumbit a whole new 3/3, addressing the whole comment
issues all at once?
- Should I just wait on the outcome and proceed from there?
Advice would be appreciated.
Anyway, I will be sending some patches over other files for
the time being, paying more attention to the details.
Thanks,
~Gabriel
next prev parent reply other threads:[~2022-06-29 6:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-25 8:49 staging: Thunderbolt: ctl.c style coding issues Gabriel Viso Carrera
2022-06-25 8:49 ` [PATCH 1/3] staging: Thunderbolt: ctl.c: Fixed 2 literal " Gabriel Viso Carrera
2022-06-25 8:49 ` [PATCH 2/3] staging: Thunderbolt: ctl.c: Fixed blank line coding style issues Gabriel Viso Carrera
2022-06-25 8:49 ` [PATCH 3/3] staging: Thunderbolt: ctl.c: Fixed comment " Gabriel Viso Carrera
2022-06-25 9:37 ` Joe Perches
2022-06-29 6:54 ` Gabriel Viso Carrera [this message]
2022-06-29 7:02 ` Greg KH
2022-06-29 7:47 ` Gabriel Viso Carrera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yrv3PTCgzZGu3l8j@vao \
--to=gabriel@gvisoc.com \
--cc=andreas.noever@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox