[PATCH] drivers: android: bind_alloc: asm/cacheflush to linux/cacheflush

[PATCH] drivers: android: bind_alloc: asm/cacheflush to linux/cacheflush

[Shinyzenith]

* Removing checkpatch warnings.
* No functional changes.

Signed-off-by: Shinyzenith <aakashsensharma@gmail.com>
---
 drivers/android/binder_alloc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c
index 5649a0371a1f..795132af0c15 100644
--- a/drivers/android/binder_alloc.c
+++ b/drivers/android/binder_alloc.c
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-only
-/* binder_alloc.c
- *
+/*
  * Android IPC Subsystem
  *
  * Copyright (C) 2007-2017 Google, Inc.
@@ -19,7 +18,7 @@
 #include <linux/sched.h>
 #include <linux/list_lru.h>
 #include <linux/ratelimit.h>
-#include <asm/cacheflush.h>
+#include <linux/cacheflush.h>
 #include <linux/uaccess.h>
 #include <linux/highmem.h>
 #include <linux/sizes.h>
-- 
2.37.0

Re: [PATCH] drivers: android: bind_alloc: asm/cacheflush to linux/cacheflush

[Greg KH]

On Tue, Jul 12, 2022 at 03:00:59AM +0530, Shinyzenith wrote:
> * Removing checkpatch warnings.
> * No functional changes.
> 
> Signed-off-by: Shinyzenith <aakashsensharma@gmail.com>
> ---
>  drivers/android/binder_alloc.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c
> index 5649a0371a1f..795132af0c15 100644
> --- a/drivers/android/binder_alloc.c
> +++ b/drivers/android/binder_alloc.c
> @@ -1,6 +1,5 @@
>  // SPDX-License-Identifier: GPL-2.0-only
> -/* binder_alloc.c
> - *
> +/*
>   * Android IPC Subsystem
>   *
>   * Copyright (C) 2007-2017 Google, Inc.
> @@ -19,7 +18,7 @@
>  #include <linux/sched.h>
>  #include <linux/list_lru.h>
>  #include <linux/ratelimit.h>
> -#include <asm/cacheflush.h>
> +#include <linux/cacheflush.h>
>  #include <linux/uaccess.h>
>  #include <linux/highmem.h>
>  #include <linux/sizes.h>
> -- 
> 2.37.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH] drivers: android: bind_alloc: asm/cacheflush to linux/cacheflush

[Greg KH]

On Tue, Jul 12, 2022 at 03:00:59AM +0530, Shinyzenith wrote:
> * Removing checkpatch warnings.
> * No functional changes.
> 
> Signed-off-by: Shinyzenith <aakashsensharma@gmail.com>
> ---
>  drivers/android/binder_alloc.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c
> index 5649a0371a1f..795132af0c15 100644
> --- a/drivers/android/binder_alloc.c
> +++ b/drivers/android/binder_alloc.c
> @@ -1,6 +1,5 @@
>  // SPDX-License-Identifier: GPL-2.0-only
> -/* binder_alloc.c
> - *
> +/*
>   * Android IPC Subsystem
>   *
>   * Copyright (C) 2007-2017 Google, Inc.
> @@ -19,7 +18,7 @@
>  #include <linux/sched.h>
>  #include <linux/list_lru.h>
>  #include <linux/ratelimit.h>
> -#include <asm/cacheflush.h>
> +#include <linux/cacheflush.h>
>  #include <linux/uaccess.h>
>  #include <linux/highmem.h>
>  #include <linux/sizes.h>
> -- 
> 2.37.0
> 

Including the issues found by my patch bot, please consider working in
drivers/staging/ first and not in other portions of the kernel, so that
you can learn the proper processes and development model and not bother
maintainers of other subsystems.

Note, you also forgot to send your change to the correct people for
review.

thanks,

greg k-h

Re: [PATCH] drivers: android: bind_alloc: asm/cacheflush to linux/cacheflush

[Aakash Sen Sharma]

On Tue Jul 12, 2022 at 11:01 AM IST, Greg KH wrote:
> Including the issues found by my patch bot, please consider working in
> drivers/staging/ first and not in other portions of the kernel, so that
> you can learn the proper processes and development model and not bother
> maintainers of other subsystems.
>
> Note, you also forgot to send your change to the correct people for
> review.
>
> thanks,
>
> greg k-h

Apologies. 

I'm still trying to get a grasp of the entire process and
diving into the main tree itself feels intimidating hence I was
submitting simple cleanup patches.

I will keep your advice in mind the next time!

thanks,
Aakash Sen Sharma.