From: Greg KH <gregkh@linuxfoundation.org>
To: Shinyzenith <aakashsensharma@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: android: bind_alloc: asm/cacheflush to linux/cacheflush
Date: Tue, 12 Jul 2022 07:31:29 +0200 [thread overview]
Message-ID: <Ys0HMXzpjZX+kVsD@kroah.com> (raw)
In-Reply-To: <20220711213059.7197-1-aakashsensharma@gmail.com>
On Tue, Jul 12, 2022 at 03:00:59AM +0530, Shinyzenith wrote:
> * Removing checkpatch warnings.
> * No functional changes.
>
> Signed-off-by: Shinyzenith <aakashsensharma@gmail.com>
> ---
> drivers/android/binder_alloc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c
> index 5649a0371a1f..795132af0c15 100644
> --- a/drivers/android/binder_alloc.c
> +++ b/drivers/android/binder_alloc.c
> @@ -1,6 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0-only
> -/* binder_alloc.c
> - *
> +/*
> * Android IPC Subsystem
> *
> * Copyright (C) 2007-2017 Google, Inc.
> @@ -19,7 +18,7 @@
> #include <linux/sched.h>
> #include <linux/list_lru.h>
> #include <linux/ratelimit.h>
> -#include <asm/cacheflush.h>
> +#include <linux/cacheflush.h>
> #include <linux/uaccess.h>
> #include <linux/highmem.h>
> #include <linux/sizes.h>
> --
> 2.37.0
>
Including the issues found by my patch bot, please consider working in
drivers/staging/ first and not in other portions of the kernel, so that
you can learn the proper processes and development model and not bother
maintainers of other subsystems.
Note, you also forgot to send your change to the correct people for
review.
thanks,
greg k-h
next prev parent reply other threads:[~2022-07-12 5:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 21:30 [PATCH] drivers: android: bind_alloc: asm/cacheflush to linux/cacheflush Shinyzenith
2022-07-12 5:30 ` Greg KH
2022-07-12 5:31 ` Greg KH [this message]
2022-07-12 5:35 ` Aakash Sen Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ys0HMXzpjZX+kVsD@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aakashsensharma@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox