public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ben Kao <ben.kao@intel.com>
Cc: mathias.nyman@intel.com, mathias.nyman@linux.intel.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xhci-pci: Enable runtime PM on Alder Lake-N PCH xHCI controller
Date: Tue, 12 Jul 2022 14:44:53 +0200	[thread overview]
Message-ID: <Ys1sxRT0i/NXSui7@kroah.com> (raw)
In-Reply-To: <20220712122442.22504-1-ben.kao@intel.com>

On Tue, Jul 12, 2022 at 08:24:42PM +0800, Ben Kao wrote:
> There are two Alder Lake-N xHCI host controllers with PCI IDs
> 0x464e and 0x54ed, now we add the quirk to default enable runtime
> PM for 0x54ed.
> 
> Signed-off-by: Ben Kao <ben.kao@intel.com>
> ---
>  drivers/usb/host/xhci-pci.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index dce6c0ec8d34..44486156bd5d 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -61,6 +61,7 @@
>  #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_XHCI		0x461e
>  #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_XHCI		0x464e
>  #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_PCH_XHCI	0x51ed
> +#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_PCH_XHCI	0x54ed

I think we ask this every time, but why don't we enable this for all
devices and then only disable it for the tiny number that don't need it?

Why do you all force us to add this for every new device created?

thanks,

greg k-h

  reply	other threads:[~2022-07-12 12:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-12 12:24 [PATCH] xhci-pci: Enable runtime PM on Alder Lake-N PCH xHCI controller Ben Kao
2022-07-12 12:44 ` Greg KH [this message]
2022-07-14  9:06   ` Kao, Ben
2022-07-14 13:49     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ys1sxRT0i/NXSui7@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ben.kao@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=mathias.nyman@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox