From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Tim Van Patten <timvp@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
rrangel@chromium.org, robbarnes@google.com,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH v2] platform/chrome: cros_ec: Send host event for prepare/complete
Date: Wed, 13 Jul 2022 02:58:03 +0000 [thread overview]
Message-ID: <Ys40uw4QIe4fQKA/@google.com> (raw)
In-Reply-To: <20220706205136.v2.1.Ic7a7c81f880ab31533652e0928aa6e687bb268b5@changeid>
On Wed, Jul 06, 2022 at 08:51:39PM -0600, Tim Van Patten wrote:
> Update cros_ec_lpc_pm_ops to call cros_ec_lpc_suspend() during PM
> .prepare() and cros_ec_lpc_resume() during .complete. This allows the
> EC to log entry/exit of AP's suspend/resume more accurately.
Please be consistent. Either way:
- .prepare and .complete.
- .prepare() and .complete().
The patch doesn't allow EC to log anything. It makes AP emit more logs.
On the related note, the commit subject is confusing. The patch doesn't
send "host event". "host event" is a terminology when EC wants to notify
AP something. Also, s/cros_ec/cros_ec_lpcs/.
> Changes in v2:
> - Include cros_ec_resume() return value in dev_info() output.
> - Guard setting .prepare/.complete with #ifdef CONFIG_PM_SLEEP.
I didn't see concerns in [1] have been addressed.
[1]: https://patchwork.kernel.org/project/chrome-platform/patch/20220701095421.1.I78ded92e416b55de31975686d34b2058d4761c07@changeid/#24920824
next prev parent reply other threads:[~2022-07-13 2:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 2:51 [PATCH v2] platform/chrome: cros_ec: Send host event for prepare/complete Tim Van Patten
2022-07-13 2:58 ` Tzung-Bi Shih [this message]
[not found] ` <CANkg5eyehcECGeDHBEsxR=iOoyMwzkcpvX+oRxy7PJPYLD=VuQ@mail.gmail.com>
2022-07-14 2:22 ` Tzung-Bi Shih
2022-07-14 18:19 ` Tim Van Patten
2022-07-14 18:34 ` Prashant Malani
2022-07-14 20:55 ` Tim Van Patten
2022-07-14 21:51 ` Prashant Malani
2022-07-14 22:17 ` Tim Van Patten
2022-07-14 23:33 ` Prashant Malani
2022-08-01 23:33 ` Tim Van Patten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ys40uw4QIe4fQKA/@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robbarnes@google.com \
--cc=rrangel@chromium.org \
--cc=timvp@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox