From: Johan Hovold <johan@kernel.org>
To: Jiang Jian <jiangjian@cdjrlc.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: cypress_m8: drop unexpected word "the" in the comments
Date: Wed, 13 Jul 2022 08:43:56 +0200 [thread overview]
Message-ID: <Ys5prITWZSfLcZjp@hovoldconsulting.com> (raw)
In-Reply-To: <20220622104608.8871-1-jiangjian@cdjrlc.com>
On Wed, Jun 22, 2022 at 06:46:08PM +0800, Jiang Jian wrote:
> there is an unexpected word "the" in the comments that need to be dropped
>
> file: drivers/usb/serial/cypress_m8.c
> line: 259
>
> * chose to use the the general purpose firmware or not), if you
> changed to:
> * chose to use the general purpose firmware or not), if you
>
> Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
> ---
> drivers/usb/serial/cypress_m8.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
> index 6924fa95f6bd..da8913683104 100644
> --- a/drivers/usb/serial/cypress_m8.c
> +++ b/drivers/usb/serial/cypress_m8.c
> @@ -256,7 +256,7 @@ static int analyze_baud_rate(struct usb_serial_port *port, speed_t new_rate)
> /*
> * Mike Isely <isely@pobox.com> 2-Feb-2008: The
> * Cypress app note that describes this mechanism
> - * states the the low-speed part can't handle more
> + * states the low-speed part can't handle more
I believe the first "the" should be replaced with "that" here.
> * than 800 bytes/sec, in which case 4800 baud is the
> * safest speed for a part like that.
> */
I've fixed up the above, merged this patch with the other one for
mos7720 and amended the commit message.
The result can be found here:
https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-next
Johan
prev parent reply other threads:[~2022-07-13 6:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 10:46 [PATCH] USB: serial: cypress_m8: drop unexpected word "the" in the comments Jiang Jian
2022-07-13 6:43 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ys5prITWZSfLcZjp@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jiangjian@cdjrlc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox