From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 317E3C43334 for ; Wed, 13 Jul 2022 07:24:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231836AbiGMHYU (ORCPT ); Wed, 13 Jul 2022 03:24:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234158AbiGMHYP (ORCPT ); Wed, 13 Jul 2022 03:24:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1BDFA58FE for ; Wed, 13 Jul 2022 00:24:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5AE85B81D53 for ; Wed, 13 Jul 2022 07:24:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 937B1C3411E; Wed, 13 Jul 2022 07:24:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657697052; bh=Jfaqpz4SNBajpuUinidVA+7dT+UHlgGv8dACmnXz688=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KsMHKPnDhC6PLCFiJH0tdMMg65Eoo0Pqmsj7JTTD+Cigi52kNO+0b9ykySa87dxLy VYghbmZBsY2+UNI5UN86QI3hprEGy5ooh5zkFOm+4Lzex+AUVUkgX7pbZZBSnnT/nt KWiT27nn6X40FfEg5D2vsjvjf9GWL6J9FF67slUY= Date: Wed, 13 Jul 2022 09:24:09 +0200 From: Greg Kroah-Hartman To: Nathan Chancellor Cc: kernel test robot , Josh Poimboeuf , llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, "Peter Zijlstra (Intel)" , Borislav Petkov , Thadeu Lima de Souza Cascardo , Ben Hutchings , Nick Desaulniers Subject: Re: [linux-stable-rc:linux-5.10.y 7109/7120] arch/x86/kernel/cpu/bugs.c:57:21: warning: section attribute is specified on redeclared variable Message-ID: References: <202207130344.AUqExE4E-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 12, 2022 at 01:24:27PM -0700, Nathan Chancellor wrote: > On Tue, Jul 12, 2022 at 01:21:15PM -0700, Nathan Chancellor wrote: > > On Wed, Jul 13, 2022 at 04:07:25AM +0800, kernel test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y > > > head: ba398a0e54049bb6a1c102245ae84103f103ff2c > > > commit: 855b78ccf1c8c952e148bdbd234cde117b098060 [7109/7120] KVM: VMX: Prevent guest RSB poisoning attacks with eIBRS > > > config: i386-randconfig-a013 (https://download.01.org/0day-ci/archive/20220713/202207130344.AUqExE4E-lkp@intel.com/config) > > > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project badda4ac3c489a8c8cccdad1f74b9308c350a9e0) > > > reproduce (this is a W=1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=855b78ccf1c8c952e148bdbd234cde117b098060 > > > git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > > > git fetch --no-tags linux-stable-rc linux-5.10.y > > > git checkout 855b78ccf1c8c952e148bdbd234cde117b098060 > > > # save the config file > > > mkdir build_dir && cp config build_dir/.config > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/kernel/ > > > > > > If you fix the issue, kindly add following tag where applicable > > > Reported-by: kernel test robot > > > > > > All warnings (new ones prefixed by >>): > > > > > > >> arch/x86/kernel/cpu/bugs.c:57:21: warning: section attribute is specified on redeclared variable [-Wsection] > > > DEFINE_PER_CPU(u64, x86_spec_ctrl_current); > > > ^ > > > arch/x86/include/asm/nospec-branch.h:278:12: note: previous declaration is here > > > extern u64 x86_spec_ctrl_current; > > > ^ > > > 1 warning generated. > > > > > > > > > vim +57 arch/x86/kernel/cpu/bugs.c > > > > > > c40221c4c496c5 Peter Zijlstra 2022-06-14 55 > > > c40221c4c496c5 Peter Zijlstra 2022-06-14 56 /* The current value of the SPEC_CTRL MSR with task-specific bits set */ > > > c40221c4c496c5 Peter Zijlstra 2022-06-14 @57 DEFINE_PER_CPU(u64, x86_spec_ctrl_current); > > > c40221c4c496c5 Peter Zijlstra 2022-06-14 58 EXPORT_SYMBOL_GPL(x86_spec_ctrl_current); > > > c40221c4c496c5 Peter Zijlstra 2022-06-14 59 > > > > > > :::::: The code at line 57 was first introduced by commit > > > :::::: c40221c4c496c5c026ede111094a96f292875d88 x86/bugs: Keep a per-CPU IA32_SPEC_CTRL value > > > > > > :::::: TO: Peter Zijlstra > > > :::::: CC: Greg Kroah-Hartman > > > > > > -- > > > 0-DAY CI Kernel Test Service > > > https://01.org/lkp > > > > > > > Looks like that declaration should be using DECLARE_PER_CPU? > > Additionally, this appears to be an issue on mainline, our CI is > starting to roll in with these patches (clang-13 + x86_64 allmodconfig): > > https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/2658541992 > > https://builds.tuxbuild.com/2Br2Q4juY6VKxbmgzULKe5C3pGq/build.log > > I am happy to send a patch if this is correct, unless someone else wants > to. Please do so. thanks, greg k-h