From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6255AC43334 for ; Wed, 13 Jul 2022 10:46:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234210AbiGMKqB (ORCPT ); Wed, 13 Jul 2022 06:46:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230147AbiGMKqA (ORCPT ); Wed, 13 Jul 2022 06:46:00 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6A1EDF9907; Wed, 13 Jul 2022 03:45:59 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 871DD1424; Wed, 13 Jul 2022 03:45:59 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4D6013F792; Wed, 13 Jul 2022 03:45:58 -0700 (PDT) Date: Wed, 13 Jul 2022 11:45:52 +0100 From: Cristian Marussi To: Christophe JAILLET Cc: Sudeep Holla , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] firmware: arm_scmi: Use the bitmap API to allocate bitmaps Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 08, 2022 at 09:30:01PM +0200, Christophe JAILLET wrote: > Use devm_bitmap_zalloc() instead of hand-writing them. > > It is less verbose and it improves the semantic. > > Signed-off-by: Christophe JAILLET > --- > drivers/firmware/arm_scmi/driver.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index 609ebedee9cb..b1265732d83a 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -1911,8 +1911,8 @@ static int __scmi_xfer_info_init(struct scmi_info *sinfo, > hash_init(info->pending_xfers); > > /* Allocate a bitmask sized to hold MSG_TOKEN_MAX tokens */ > - info->xfer_alloc_table = devm_kcalloc(dev, BITS_TO_LONGS(MSG_TOKEN_MAX), > - sizeof(long), GFP_KERNEL); > + info->xfer_alloc_table = devm_bitmap_zalloc(dev, MSG_TOKEN_MAX, > + GFP_KERNEL); > if (!info->xfer_alloc_table) > return -ENOMEM; > LGTM. Reviewed-by: Cristian Marussi Tested-by: Cristian Marussi Thanks, Cristian