From: sdf@google.com
To: Francis Laniel <flaniel@linux.microsoft.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
bpf <bpf@vger.kernel.org>, Quentin Monnet <quentin@isovalent.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/1] bpftool: Align dumped file generated header with skeletons.
Date: Wed, 13 Jul 2022 09:03:10 -0700 [thread overview]
Message-ID: <Ys7svh29R5jA6QAr@google.com> (raw)
In-Reply-To: <4411407.LvFx2qVVIh@pwmachine>
On 07/13, Francis Laniel wrote:
> Le mercredi 13 juillet 2022, 16:47:17 CEST Alexei Starovoitov a �crit :
> > On Wed, Jul 13, 2022 at 7:45 AM Francis Laniel
> >
> > <flaniel@linux.microsoft.com> wrote:
> > > This commit adds the following lines to file generated by dump:
> > > /* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */
> > > /* THIS FILE IS AUTOGENERATED BY BPFTOOL! */
> > > Hence, the dumped file headers follows that of skeletons.
> > >
> > > Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
> > > ---
> > >
> > > tools/bpf/bpftool/btf.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/tools/bpf/bpftool/btf.c b/tools/bpf/bpftool/btf.c
> > > index 7e6accb9d9f7..066a0acd0ecd 100644
> > > --- a/tools/bpf/bpftool/btf.c
> > > +++ b/tools/bpf/bpftool/btf.c
> > > @@ -425,6 +425,8 @@ static int dump_btf_c(const struct btf *btf,
> > >
> > > if (err)
> > >
> > > return err;
> > >
> > > + printf("/* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause)
> > > */\n");
> > This was discussed earlier. It's incorrect and we cannot add just header
> > to vmlinux.h
> Oops sorry, I will send a v4 dropping it.
> Nonetheless can you please send me a link for a discussion about this?
+1, Google only gives me the following:
https://lore.kernel.org/bpf/87czmwe26c.fsf@toke.dk/T/
(which is somewhat inconclusive?)
prev parent reply other threads:[~2022-07-13 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 14:44 [PATCH v3 0/1] bpftool: Align dumped file headers with skeletons Francis Laniel
2022-07-13 14:44 ` [PATCH v3 1/1] bpftool: Align dumped file generated header " Francis Laniel
2022-07-13 14:47 ` Alexei Starovoitov
2022-07-13 14:53 ` Francis Laniel
2022-07-13 16:03 ` sdf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ys7svh29R5jA6QAr@google.com \
--to=sdf@google.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=flaniel@linux.microsoft.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=quentin@isovalent.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox