From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF3D6C433EF for ; Mon, 4 Jul 2022 17:26:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234414AbiGDR0T (ORCPT ); Mon, 4 Jul 2022 13:26:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233785AbiGDR0S (ORCPT ); Mon, 4 Jul 2022 13:26:18 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D551120BD; Mon, 4 Jul 2022 10:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2O7jbtUUBQdght/8/u2Xd4jdIRo54n9MTaKJeIIYcDY=; b=e/Jz5LeczVAr2Gb17LAJQAOzek V76VFKC10UMt+zc8aSes6NPC8R7cwGFH5NQ8dP9c5Btc5RFT/RBkvqYfgW/FeQsniafImfOSE3OJx MKyqPinerqrKwho/jrTbS5rvlPNLxEMwUOIHfGXFRGGkuNGdUE/5nDDDbNrZkD9IkdhypDeUaj4Se AH5fgPj+v2Jn12Jq/2r2w6SCgXM0Dw6jKOyWW8YXTW0GT9Pmy1wcqYaN3J+ZzqlNhziyWUKBrskDR NVAErJeff4lczaD/MxuIjsbUGEn8LoRlcLfs9F+INleXMUSfd/tlMm4qyFBFxslgACkwhJf7+Z5N5 FevJu5cA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8Ppo-00HSn3-IM; Mon, 04 Jul 2022 17:26:08 +0000 Date: Mon, 4 Jul 2022 18:26:08 +0100 From: Matthew Wilcox To: Alexander Gordeev Cc: Greg Kroah-Hartman , Heiko Carstens , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Baoquan He , Christoph Hellwig , Andrew Morton , Sasha Levin , Vasily Gorbik Subject: Re: [PATCH 5.18 112/181] vmcore: convert copy_oldmem_page() to take an iov_iter Message-ID: References: <20220627111944.553492442@linuxfoundation.org> <20220627111947.945731832@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 28, 2022 at 10:29:04AM +0200, Alexander Gordeev wrote: > On Tue, Jun 28, 2022 at 09:09:05AM +0200, Greg Kroah-Hartman wrote: > > > This one breaks s390. You would also need to apply the following two commits: > > > > > > cc02e6e21aa5 ("s390/crash: add missing iterator advance in copy_oldmem_page()") > > > af2debd58bd7 ("s390/crash: make copy_oldmem_page() return number of bytes copied") > > > > Both of them are also in the 5.18-rc queue here, right? > > Yes, these are: > > [PATCH 5.18 113/181] s390/crash: add missing iterator advance in copy_oldmem_page() Greg Kroah-Hartman It's generally considered polite to cc the original author when you fix one of their patches. I wasn't aware of this patch. While the code change looks right, the commit message is wrong; copy_oldmem_user() and copy_oldmem_kernel() need to GO AWAY. You need to be more like the other architectures and end up calling copy_to_iter(). I have no idea what this memcpy_hsa_kernel() and memcpy_hsa_user() are all about, but I was hoping that somebody from the s390 team would react to: s390 needs more work to pass the iov_iter down further, or refactor, but I'd be more comfortable if someone who can test on s390 did that work. Maybe you'll do it.