Re: [PATCH] MAINTAINERS: adjust XDP SOCKETS after file movement

Maciej Fijalkowski
2022-07-01T13:52:58Z

On Fri, Jul 01, 2022 at 03:13:36PM +0200, Magnus Karlsson wrote:
> On Fri, Jul 1, 2022 at 2:38 PM Maciej Fijalkowski
> <maciej.fijalkowski@intel.com> wrote:
> >
> > On Fri, Jul 01, 2022 at 06:28:10AM +0200, Lukas Bulwahn wrote:
> > > Commit f36600634282 ("libbpf: move xsk.{c,h} into selftests/bpf") moves
> > > files tools/{lib => testing/selftests}/bpf/xsk.[ch], but misses to adjust
> > > the XDP SOCKETS (AF_XDP) section in MAINTAINERS.
> > >
> > > Adjust the file entry after this file movement.
> > >
> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > > ---
> > > Andrii, please ack.
> > >
> > > Alexei, please pick this minor non-urgent clean-up on top of the commit above.
> > >
> > > MAINTAINERS | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index fa4bfa3d10bf..27d9e65b9a85 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -22042,7 +22042,7 @@ F: include/uapi/linux/xdp_diag.h
> > > F: include/net/netns/xdp.h
> > > F: net/xdp/
> > > F: samples/bpf/xdpsock*
> > > -F: tools/lib/bpf/xsk*
> > > +F: tools/testing/selftests/bpf/xsk*
> >
> > Magnus, this doesn't cover xdpxceiver.
> > How about we move the lib part and xdpxceiver part to a dedicated
> > directory? Or would it be too nested from main dir POV?
>
> Or we can just call everything we add xsk* something?

No strong feelings. test_xsk.sh probably also needs to be addressed.
That's why I proposed dedicated dir.

>
> > >
> > > XEN BLOCK SUBSYSTEM
> > > M: Roger Pau Monné <roger.pau@citrix.com>
> > > --
> > > 2.17.1
> > >