From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9B82C43334 for ; Tue, 5 Jul 2022 17:30:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233396AbiGERaJ (ORCPT ); Tue, 5 Jul 2022 13:30:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233398AbiGER3l (ORCPT ); Tue, 5 Jul 2022 13:29:41 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED493220C4 for ; Tue, 5 Jul 2022 10:28:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zR33MMpcXSEF0WEP/osw4umkJspfbWxY04cS0PgwShs=; b=mrjGcebVMenj5+hil2MAPSiZWn +JHIPNzEJKTEC9lYVX9FfR29NI5dP+VRe0npgpci241LG64jTrJGc7qzFCXVncSe3SyaQXTpxJHgZ y8cenUsGJWrzDcjMTPLZELCff1DtC7AKbsteD8+1s9/bGGebg2G35LefJaRz1ZvEc6BYbDnaEvfii h1dD4sl/UCP2t+o5Xm4Hxq2VRpnTA4+7aLO0E6OgmvrEUyApLFXTtDYoIjGEjPhiJcNPBYJnqouF9 jQvj/6OZzZDMBWq8vMc5qbnwRCCwhTZj383Z+ptu4uOuhVpG30ca48tvof+Zqs2KWJcB4rKK8hT3U C+YfziPA==; Received: from dhcp-077-249-017-003.chello.nl ([77.249.17.3] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8mLt-000mJ9-3l; Tue, 05 Jul 2022 17:28:45 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 628F6980059; Tue, 5 Jul 2022 19:28:43 +0200 (CEST) Date: Tue, 5 Jul 2022 19:28:43 +0200 From: Peter Zijlstra To: Nicholas Piggin Cc: Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/13] locking/qspinlock: stop renaming queued_spin_lock_slowpath to native_queued_spin_lock_slowpath Message-ID: References: <20220704143820.3071004-1-npiggin@gmail.com> <20220704143820.3071004-9-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220704143820.3071004-9-npiggin@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 05, 2022 at 12:38:15AM +1000, Nicholas Piggin wrote: > The native version can simply be queued_spin_lock_slowpath, and the > paravirt version __pv_queued_spin_lock_slowpath, which is as they are > named in the C code. > Humm... so it is the x86 paravirt convention to have native_*() functions for everthing, which sometimes are unconditionally called whenever the paravirt indirection is unwarranted etc.. I suppose that's not the case with the spinlock code thouhg, so yeah, why not.