Re: [PATCH] dmaengine: lgm: Fix an error handling path in intel_ldma_probe()

Vinod Koul
2022-07-06T05:23:57Z

On 22-05-22, 19:41, Christophe JAILLET wrote:
> ldma_clk_disable() calls both:
> clk_disable_unprepare(d->core_clk);
> reset_control_assert(d->rst);
>
> So, should devm_reset_control_get_optional() fail, core_clk should not
> be prepare_enable'd before it, otherwise it will never be
> disable_unprepare'd.
>
> Reorder the code to handle the error handling path as expected.

Applied, thanks

--
~Vinod