* [PATCH] dmaengine: altera: Fix kernel-doc
@ 2022-05-25 9:33 Jiapeng Chong
2022-05-26 20:15 ` Olivier dautricourt
2022-07-06 5:37 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2022-05-25 9:33 UTC (permalink / raw)
To: olivierdautricourt
Cc: sr, vkoul, dmaengine, linux-kernel, Jiapeng Chong, Abaci Robot
Fix the following W=1 kernel warnings:
drivers/dma/altera-msgdma.c:927: warning: expecting prototype for
msgdma_dma_remove(). Prototype was for msgdma_remove() instead.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/dma/altera-msgdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c
index 6f56dfd375e3..bdaac5d62a04 100644
--- a/drivers/dma/altera-msgdma.c
+++ b/drivers/dma/altera-msgdma.c
@@ -918,7 +918,7 @@ static int msgdma_probe(struct platform_device *pdev)
}
/**
- * msgdma_dma_remove - Driver remove function
+ * msgdma_remove() - Driver remove function
* @pdev: Pointer to the platform_device structure
*
* Return: Always '0'
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: altera: Fix kernel-doc
2022-05-25 9:33 [PATCH] dmaengine: altera: Fix kernel-doc Jiapeng Chong
@ 2022-05-26 20:15 ` Olivier dautricourt
2022-07-06 5:37 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Olivier dautricourt @ 2022-05-26 20:15 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: sr, vkoul, dmaengine, linux-kernel, Abaci Robot
On Wed, May 25, 2022 at 05:33:13PM +0800, Jiapeng Chong wrote:
> Fix the following W=1 kernel warnings:
>
> drivers/dma/altera-msgdma.c:927: warning: expecting prototype for
> msgdma_dma_remove(). Prototype was for msgdma_remove() instead.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/dma/altera-msgdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c
> index 6f56dfd375e3..bdaac5d62a04 100644
> --- a/drivers/dma/altera-msgdma.c
> +++ b/drivers/dma/altera-msgdma.c
> @@ -918,7 +918,7 @@ static int msgdma_probe(struct platform_device *pdev)
> }
>
> /**
> - * msgdma_dma_remove - Driver remove function
> + * msgdma_remove() - Driver remove function
> * @pdev: Pointer to the platform_device structure
> *
> * Return: Always '0'
> --
> 2.20.1.7.g153144c
>
Hello, thanks for reporting.
I notice now that another doc entry is misnamed:
drivers/dma/altera-msgdma.c:758: warning: expecting prototype for
msgdma_chan_remove(). Prototype was for msgdma_dev_remove() instead
Is it possible for you to fix this aswell ?
I also suggest using the full name of the driver in the commit message:
dmaengine: altera-msgdma: ...
Kr,
Olivier
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: altera: Fix kernel-doc
2022-05-25 9:33 [PATCH] dmaengine: altera: Fix kernel-doc Jiapeng Chong
2022-05-26 20:15 ` Olivier dautricourt
@ 2022-07-06 5:37 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2022-07-06 5:37 UTC (permalink / raw)
To: Jiapeng Chong
Cc: olivierdautricourt, sr, dmaengine, linux-kernel, Abaci Robot
On 25-05-22, 17:33, Jiapeng Chong wrote:
> Fix the following W=1 kernel warnings:
>
> drivers/dma/altera-msgdma.c:927: warning: expecting prototype for
> msgdma_dma_remove(). Prototype was for msgdma_remove() instead.
Commit title should describe the change and not the effect, pls revise
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/dma/altera-msgdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c
> index 6f56dfd375e3..bdaac5d62a04 100644
> --- a/drivers/dma/altera-msgdma.c
> +++ b/drivers/dma/altera-msgdma.c
> @@ -918,7 +918,7 @@ static int msgdma_probe(struct platform_device *pdev)
> }
>
> /**
> - * msgdma_dma_remove - Driver remove function
> + * msgdma_remove() - Driver remove function
> * @pdev: Pointer to the platform_device structure
> *
> * Return: Always '0'
> --
> 2.20.1.7.g153144c
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-06 5:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-25 9:33 [PATCH] dmaengine: altera: Fix kernel-doc Jiapeng Chong
2022-05-26 20:15 ` Olivier dautricourt
2022-07-06 5:37 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox