From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BF40C43334 for ; Wed, 6 Jul 2022 11:38:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231693AbiGFLil (ORCPT ); Wed, 6 Jul 2022 07:38:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229898AbiGFLij (ORCPT ); Wed, 6 Jul 2022 07:38:39 -0400 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBB5114024 for ; Wed, 6 Jul 2022 04:38:38 -0700 (PDT) Received: by theia.8bytes.org (Postfix, from userid 1000) id 4018F4CC; Wed, 6 Jul 2022 13:38:37 +0200 (CEST) Date: Wed, 6 Jul 2022 13:38:36 +0200 From: Joerg Roedel To: Bo Liu Cc: will@kernel.org, suravee.suthikulpanit@amd.com, iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/amd: Handle return of iommu_device_sysfs_add Message-ID: References: <20220701062008.6988-1-liubo03@inspur.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220701062008.6988-1-liubo03@inspur.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 01, 2022 at 02:20:08AM -0400, Bo Liu wrote: > As iommu_device_sysfs_add() can fail, we should check the return value. > > Signed-off-by: Bo Liu > --- > drivers/iommu/amd/init.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Applied, thanks.