public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Shengjiu Wang <shengjiu.wang@gmail.com>
Cc: Shengjiu Wang <shengjiu.wang@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	joy.zou@nxp.com, NXP Linux Team <linux-imx@nxp.com>,
	dmaengine@vger.kernel.org,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
	<linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] dmaengine: imx-sdma: Add FIFO stride support for multi FIFO script
Date: Wed, 6 Jul 2022 21:59:20 +0530	[thread overview]
Message-ID: <YsW4YHL9+HkQndva@matsya> (raw)
In-Reply-To: <CAA+D8AOST1wK0G=65ufrhPrH8AQ0w-r1pMF5DOnqBauQtx7AOg@mail.gmail.com>

On 06-07-22, 14:54, Shengjiu Wang wrote:
> On Wed, Jul 6, 2022 at 2:00 PM Vinod Koul <vkoul@kernel.org> wrote:
> 
> > On 21-06-22, 11:36, Shengjiu Wang wrote:
> > > The peripheral may have several FIFOs, but some case just select
> > > some FIFOs from them for data transfer, which means FIFO0 and FIFO2
> > > may be selected. So add FIFO address stride support, 0 means all FIFOs
> > > are continuous, 1 means 1 word stride between FIFOs. All stride between
> > > FIFOs should be same.
> > >
> > > Another option words_per_fifo means how many audio channel data copied
> > > to one FIFO one time, 1 means one channel per FIFO, 2 means 2 channels
> > > per FIFO.
> > >
> > > If 'n_fifos_src =  4' and 'words_per_fifo = 2', it means the first two
> > > words(channels) fetch from FIFO0 and then jump to FIFO1 for next two
> > words,
> > > and so on after the last FIFO3 fetched, roll back to FIFO0.
> >
> > this fails to apply for me, pls rebase on dmaengine/next and revise
> >
> >
> > it based on my another commit, the one that fixes the struct documentation
> should I send them together?

Pls mention that in patch title.. I have applied that, so rebase and
resend please

-- 
~Vinod

      parent reply	other threads:[~2022-07-06 16:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-21  3:36 [PATCH v3] dmaengine: imx-sdma: Add FIFO stride support for multi FIFO script Shengjiu Wang
2022-07-06  6:00 ` Vinod Koul
     [not found]   ` <CAA+D8AOST1wK0G=65ufrhPrH8AQ0w-r1pMF5DOnqBauQtx7AOg@mail.gmail.com>
2022-07-06 16:29     ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YsW4YHL9+HkQndva@matsya \
    --to=vkoul@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=joy.zou@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=shengjiu.wang@gmail.com \
    --cc=shengjiu.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox