From: Andi Shyti <andi.shyti@linux.intel.com>
To: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
DRI Devel <dri-devel@lists.freedesktop.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Stable <stable@vger.kernel.org>,
Mark Janes <mark.janes@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
Chris Wilson <chris.p.wilson@linux.intel.com>,
Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH] drm/i915/gem: Really move i915_gem_context.link under ref protection
Date: Thu, 7 Jul 2022 00:34:08 +0200 [thread overview]
Message-ID: <YsYN4OMKanJMPcjv@alfio.lan> (raw)
In-Reply-To: <20220706152924.73926-1-andi.shyti@linux.intel.com>
Hi,
[...]
> @@ -1265,10 +1264,15 @@ static void i915_gem_context_release_work(struct work_struct *work)
> struct i915_gem_context *ctx = container_of(work, typeof(*ctx),
> release_work);
> struct i915_address_space *vm;
> + unsigned long flags;
>
> trace_i915_context_free(ctx);
> GEM_BUG_ON(!i915_gem_context_is_closed(ctx));
>
> + spin_lock_irqsave(&ctx->i915->gem.contexts.lock, flags);
> + list_del(&ctx->link);
> + spin_unlock_irqrestore(&ctx->i915->gem.contexts.lock, flags);
> +
yah! this can't work from a worker.
Andi
prev parent reply other threads:[~2022-07-06 22:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 15:29 [PATCH] drm/i915/gem: Really move i915_gem_context.link under ref protection Andi Shyti
2022-07-06 22:34 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsYN4OMKanJMPcjv@alfio.lan \
--to=andi.shyti@linux.intel.com \
--cc=andi@etezian.org \
--cc=chris.p.wilson@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.janes@intel.com \
--cc=stable@vger.kernel.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox