[RFC v2] driver core: Fix repeated device_is_dependent check for same link

[RFC v2] driver core: Fix repeated device_is_dependent check for same link

[Abel Vesa]

In case of a cyclic dependency, if the supplier is not yet available,
the parent of the supplier is checked for dependency. But if there are
more than one suppliers with the same parent, the first check returns
true while the next ones skip that specific link entirely because of
having DL_FLAG_MANAGED and DL_FLAG_SYNC_STATE_ONLY set, which is what
the relaxing of the link does. But if we check for the target being
a consumer before the check for those flags, we can check as many
times as needed the same link and it will always return true, This is
safe to do, since the relaxing of the link will be done only once
because those flags will be set and it will bail early.

Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 drivers/base/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 753e7cca0f40..2c3b860dfe80 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -297,13 +297,13 @@ int device_is_dependent(struct device *dev, void *target)
 		return ret;

 	list_for_each_entry(link, &dev->links.consumers, s_node) {
+		if (link->consumer == target)
+			return 1;
+
 		if ((link->flags & ~DL_FLAG_INFERRED) ==
 		    (DL_FLAG_SYNC_STATE_ONLY | DL_FLAG_MANAGED))
 			continue;

-		if (link->consumer == target)
-			return 1;
-
 		ret = device_is_dependent(link->consumer, target);
 		if (ret)
 			break;
--
2.34.3

Re: [RFC v2] driver core: Fix repeated device_is_dependent check for same link

[Greg Kroah-Hartman]

On Wed, Jul 06, 2022 at 06:53:47PM +0300, Abel Vesa wrote:
> In case of a cyclic dependency, if the supplier is not yet available,
> the parent of the supplier is checked for dependency. But if there are
> more than one suppliers with the same parent, the first check returns
> true while the next ones skip that specific link entirely because of
> having DL_FLAG_MANAGED and DL_FLAG_SYNC_STATE_ONLY set, which is what
> the relaxing of the link does. But if we check for the target being
> a consumer before the check for those flags, we can check as many
> times as needed the same link and it will always return true, This is
> safe to do, since the relaxing of the link will be done only once
> because those flags will be set and it will bail early.
> 
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  drivers/base/core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 753e7cca0f40..2c3b860dfe80 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -297,13 +297,13 @@ int device_is_dependent(struct device *dev, void *target)
>  		return ret;
> 
>  	list_for_each_entry(link, &dev->links.consumers, s_node) {
> +		if (link->consumer == target)
> +			return 1;
> +
>  		if ((link->flags & ~DL_FLAG_INFERRED) ==
>  		    (DL_FLAG_SYNC_STATE_ONLY | DL_FLAG_MANAGED))
>  			continue;
> 
> -		if (link->consumer == target)
> -			return 1;
> -
>  		ret = device_is_dependent(link->consumer, target);
>  		if (ret)
>  			break;
> --
> 2.34.3
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/SubmittingPatches for what needs to be done
  here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [RFC v2] driver core: Fix repeated device_is_dependent check for same link

[Saravana Kannan]

On Wed, Jul 6, 2022 at 8:54 AM Abel Vesa <abel.vesa@linaro.org> wrote:
>
> In case of a cyclic dependency, if the supplier is not yet available,
> the parent of the supplier is checked for dependency. But if there are
> more than one suppliers with the same parent, the first check returns
> true while the next ones skip that specific link entirely because of
> having DL_FLAG_MANAGED and DL_FLAG_SYNC_STATE_ONLY set, which is what
> the relaxing of the link does. But if we check for the target being
> a consumer before the check for those flags, we can check as many
> times as needed the same link and it will always return true, This is
> safe to do, since the relaxing of the link will be done only once
> because those flags will be set and it will bail early.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  drivers/base/core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 753e7cca0f40..2c3b860dfe80 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -297,13 +297,13 @@ int device_is_dependent(struct device *dev, void *target)
>                 return ret;
>
>         list_for_each_entry(link, &dev->links.consumers, s_node) {
> +               if (link->consumer == target)
> +                       return 1;
> +
>                 if ((link->flags & ~DL_FLAG_INFERRED) ==
>                     (DL_FLAG_SYNC_STATE_ONLY | DL_FLAG_MANAGED))
>                         continue;

Thanks for trying to fix this issue, but I'll have to Nack this patch.

The whole point of the SYNC_STATE_ONLY flag is to allow cycles. It's
needed to maintain correctness of sync_state(). I think I described
those in the commit text that added the SYNC_STATE_ONLY flag. Check it
out if you are interested. So this change of yours will break
sync_state() functionality.

There's a bunch of nuance to fixing the dual cycle issue and I don't
mind fixing this myself in a week or two if you can wait.

Thanks,
Saravana

>
> -               if (link->consumer == target)
> -                       return 1;
> -
>                 ret = device_is_dependent(link->consumer, target);
>                 if (ret)
>                         break;
> --
> 2.34.3
>

Re: [RFC v2] driver core: Fix repeated device_is_dependent check for same link

[Abel Vesa]

On 22-07-06 21:51:34, Saravana Kannan wrote:
> On Wed, Jul 6, 2022 at 8:54 AM Abel Vesa <abel.vesa@linaro.org> wrote:
> >
> > In case of a cyclic dependency, if the supplier is not yet available,
> > the parent of the supplier is checked for dependency. But if there are
> > more than one suppliers with the same parent, the first check returns
> > true while the next ones skip that specific link entirely because of
> > having DL_FLAG_MANAGED and DL_FLAG_SYNC_STATE_ONLY set, which is what
> > the relaxing of the link does. But if we check for the target being
> > a consumer before the check for those flags, we can check as many
> > times as needed the same link and it will always return true, This is
> > safe to do, since the relaxing of the link will be done only once
> > because those flags will be set and it will bail early.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> >  drivers/base/core.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/base/core.c b/drivers/base/core.c
> > index 753e7cca0f40..2c3b860dfe80 100644
> > --- a/drivers/base/core.c
> > +++ b/drivers/base/core.c
> > @@ -297,13 +297,13 @@ int device_is_dependent(struct device *dev, void *target)
> >                 return ret;
> >
> >         list_for_each_entry(link, &dev->links.consumers, s_node) {
> > +               if (link->consumer == target)
> > +                       return 1;
> > +
> >                 if ((link->flags & ~DL_FLAG_INFERRED) ==
> >                     (DL_FLAG_SYNC_STATE_ONLY | DL_FLAG_MANAGED))
> >                         continue;
>
> Thanks for trying to fix this issue, but I'll have to Nack this patch.
>
> The whole point of the SYNC_STATE_ONLY flag is to allow cycles. It's
> needed to maintain correctness of sync_state(). I think I described
> those in the commit text that added the SYNC_STATE_ONLY flag. Check it
> out if you are interested. So this change of yours will break
> sync_state() functionality.
>

Fair enough.

> There's a bunch of nuance to fixing the dual cycle issue and I don't
> mind fixing this myself in a week or two if you can wait.
>

Please cc me on it.

> Thanks,
> Saravana
>
> >
> > -               if (link->consumer == target)
> > -                       return 1;
> > -
> >                 ret = device_is_dependent(link->consumer, target);
> >                 if (ret)
> >                         break;
> > --
> > 2.34.3
> >