Re: [PATCH V3 1/1] ublk: add io_uring based userspace block driver

Sagi Grimberg
2022-07-04T14:00:57Z

>>> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
>>> index fdb81f2794cd..d218089cdbec 100644
>>> --- a/drivers/block/Kconfig
>>> +++ b/drivers/block/Kconfig
>>> @@ -408,6 +408,12 @@ config BLK_DEV_RBD
>>> If unsure, say N.
>>> +config BLK_DEV_UBLK
>>> + bool "Userspace block driver"
>>
>> Really? why compile this to the kernel and not tristate as loadable
>> module?
>
> So far, this is only one reason: task_work_add() is required, which
> isn't exported for modules.

So why not exporting it?
Doesn't seem like a good justification to build it into the kernel.