From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80A4CCCA480 for ; Fri, 8 Jul 2022 12:35:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238180AbiGHMfG (ORCPT ); Fri, 8 Jul 2022 08:35:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238140AbiGHMe7 (ORCPT ); Fri, 8 Jul 2022 08:34:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B357D74DEF; Fri, 8 Jul 2022 05:34:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4DD8B6271C; Fri, 8 Jul 2022 12:34:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DF34C341C6; Fri, 8 Jul 2022 12:34:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657283697; bh=szzHEteD5PBQPci+wq769nh1Ix+KwhVVbwbECRaq6ek=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2Hgp8qk4jSe6A5Xs5ZP+BN0QHqCSkSuloUkZJHtoR96mDp8pjGRKy4ekVHXf9uR2t LwiPhpZgZW/rPnYyJblhvg6Je1fzuBx6QKWLpIzAL54Vqw9Mc80/lqi1cN8slqQtSk lmj002baL80uK3U7Tbw/EOb870LlWm5pH08us2/0= Date: Fri, 8 Jul 2022 14:34:55 +0200 From: Greg KH To: Jianglei Nie Cc: pawell@cadence.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: cdnsp: Fix potential memory leak in cdnsp_alloc_stream_info() Message-ID: References: <20220706075921.2255059-1-niejianglei2021@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220706075921.2255059-1-niejianglei2021@163.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 06, 2022 at 03:59:21PM +0800, Jianglei Nie wrote: > cdnsp_alloc_stream_info() allocates stream context array for stream_info > ->stream_ctx_array with cdnsp_alloc_stream_ctx(). When some error occurs, > stream_info->stream_ctx_array is not released, which will lead to a > memory leak. > > We can fix it by releasing the stream_info->stream_ctx_array with > cdnsp_free_stream_ctx() on the error path to avoid the potential memory > leak. > > Signed-off-by: Jianglei Nie > --- > drivers/usb/cdns3/cdnsp-mem.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/cdns3/cdnsp-mem.c b/drivers/usb/cdns3/cdnsp-mem.c > index 97866bfb2da9..319037848151 100644 > --- a/drivers/usb/cdns3/cdnsp-mem.c > +++ b/drivers/usb/cdns3/cdnsp-mem.c > @@ -631,6 +631,7 @@ int cdnsp_alloc_stream_info(struct cdnsp_device *pdev, > stream_info->stream_rings[cur_stream] = NULL; > } > } > + cdnsp_free_stream_ctx(pdev, pep); > > cleanup_stream_rings: > kfree(pep->stream_info.stream_rings); > -- > 2.25.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot