From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F184C43334 for ; Sat, 9 Jul 2022 00:11:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229914AbiGIALM (ORCPT ); Fri, 8 Jul 2022 20:11:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbiGIALC (ORCPT ); Fri, 8 Jul 2022 20:11:02 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B308A7CB54 for ; Fri, 8 Jul 2022 17:11:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 27472B80907 for ; Sat, 9 Jul 2022 00:10:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3004FC341C0; Sat, 9 Jul 2022 00:10:57 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="i8NPtiG5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1657325454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9TCNIFIV8W3sMrW57L4833aHR/fFDCVNdSdZO5zn3lw=; b=i8NPtiG5zpJwnD6G6u2BkQRBMfzAo3bftZc4tO81qziuINFhgPv5Ged46rNFXuI3Czz2VK SnJY8KM4+9Rd2AZ6MLyL2C/xnNma5KiWc40wnAH87LJIoaubVC6LHmtNcNAbLnLGyL27LF +d/5mvjhkFXl58+nP6BI3XcWhynE1t8= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id a9822d4c (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sat, 9 Jul 2022 00:10:54 +0000 (UTC) Date: Sat, 9 Jul 2022 02:10:49 +0200 From: "Jason A. Donenfeld" To: Geert Uytterhoeven Cc: Laurent Vivier , Linux Kernel Mailing List , Randy Dunlap , linux-m68k , Arnd Bergmann Subject: Re: [PATCH] m68k: virt: Kconfig minor fixes Message-ID: References: <20220531174514.1586248-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On Fri, Jul 08, 2022 at 09:24:59AM +0200, Geert Uytterhoeven wrote: > Hi Jason, > > On Fri, Jul 8, 2022 at 3:25 AM Jason A. Donenfeld wrote: > > On Thu, Jun 02, 2022 at 09:13:14AM +0200, Geert Uytterhoeven wrote: > > > On Tue, May 31, 2022 at 7:45 PM Laurent Vivier wrote: > > > > Select VIRTIO_MENU as it is needed by VIRTIO_MMIO. > > > > > > > > Add an ending period at the end the virt machine help message. > > > > > > > > Reported-by: Randy Dunlap > > > > Signed-off-by: Laurent Vivier > > > > > > Reviewed-by: Geert Uytterhoeven > > > i.e. will queue in the m68k for-v5.20 branch. > > > > Shouldn't this fix make it for 5.19? It causes Kconfig warnings during > > builds. So this seems like a ordinary mid-cycle bug that can be fixed. > > > > For example, if you ctrl+f for "unmet direct" in this log, you'll see > > this splat in the wireguard CI: > > https://build.wireguard.com/random/108f4fea7b6053dfd09039af74c0ac0c32c956be/m68k.log > > These are merely configuration warnings, there is no build or runtime > failure. > I reverted this patch, disabled CONFIG_VIRTIO_MENU (which BTW defaults > to y), built and booted a kernel fine, and could login on the console. > > So IMHO it can wait. Okay, no problem. I suppose 5.19 isn't likely to be an LTS anyway. Jason